Opened 10 years ago
Closed 10 years ago
#358 closed defect (fixed)
Breaking Averaging Unit Tests
Reported by: | krzywon | Owned by: | krzywon |
---|---|---|---|
Priority: | major | Milestone: | SasView 3.1.0 |
Component: | SasView | Keywords: | |
Cc: | Work Package: | SasView Bug Fixing |
Description
Two unit tests are failing following the sans to sas conversion. The tests involve radial and sector averaging.
Change History (1)
comment:1 Changed 10 years ago by krzywon
- Resolution set to fixed
- Status changed from new to closed
Note: See
TracTickets for help on using
tickets.
The radial and sector averaging methods load in ascii data that has a Q value of 0. The ASCII reader throws out data points with this Q value. When comparing the radial average of a 2D data set (starting from 0) the first data point wouldn't match, causing the failure. I modified the test to skip the Q=0 data point and the test now passes.
The sector averaging was incorrect originally and may have been turned off before the conversion. The sectors chosen didn't match the Q values within the 'known' data set that existed. I modified the sector averaging parameters to agree with the Q range within the data set and now the test passes.