Opened 6 years ago

Last modified 5 years ago

#272 new defect

Install deletes model plugin .py files!

Reported by: smk78 Owned by:
Priority: minor Milestone: SasView Next Release +1
Component: SasView Keywords:
Cc: Work Package: SasView Bug Fixing

Description

Discovered by Richard Heenan; verified by me. Windows build.

Affects release versions 2.2.1 and 3.0.0.

Installing the SasView? release versions causes model plugin .py files
to be compiled to .pyc as expected.

However, the .py files are then being deleted!!!

And, counter-intuitively, the .pyc files are ending up in the SasView?
top level folder and not in the plugin_models sub-folder (in fact,
the latter is completely empty!)

Change History (5)

comment:1 Changed 6 years ago by ajj

Can you confirm that the .py files are being deleted from the sasview folder in the users' home directory? When are they deleted - on installation or on running SasView? (installation will not compile anything, only running sasview will).

The symptom of deletion from all relevant locations would be that there are no models in the 'Customized models' category within sasview.

The .pyc files are always generated wherever sa(n)sview.py is run from (this is a particular annoyance on linux) and so have probably always been generated in the top level directory.

comment:2 Changed 6 years ago by smk78

  • Priority changed from critical to minor

Ahh! Ok, our mistake.

The .py (and .pyc) files are in C:\Users\{user}\.sasview\plugin_models, so the .pyc must then be copied from there to C:\Program Files (x86)\SasView?. We were looking at C:\Program Files (x86)\SasView?\plugin_models. If you put a .py in the latter then what we say is true.

This could be kind of irritating to a user who doesn't know to use the app-specific location in their profile. Maybe we should 'tidy' this behaviour up?

Am downgrading priority from critical to minor.

comment:3 Changed 6 years ago by smk78

We note that when SasView? restarts newer .pyc's get generated, as you might expect. But they are generated in C:\Users\{user}\.sasview\plugin_models. Older versions of .pyc's with the same name (perhaps from initial installation compilation???) remain in C:\Program Files (x86)\SasView?\plugin_models.

Which .pyc's take priority?

comment:4 Changed 6 years ago by ajj

  • Work Package set to SasView Bug Fixing

comment:5 Changed 5 years ago by butler

We should wait till the new model interface is implemented which may change many of these things anyway and then revisit this ticket to see if it is obsolete or still needs "tidying up"

Note: See TracTickets for help on using tickets.