Opened 3 years ago

Closed 14 months ago

Last modified 14 months ago

#237 closed enhancement (fixed)

provide reader for canSAS 2d (hdf5) format

Reported by: Tobias Richter Owned by: krzywon
Priority: critical Milestone: SasView 4.0.0
Component: SasView Keywords:
Cc: Work Package: SasView Framework Enhancements

Description


Change History (16)

comment:1 Changed 3 years ago by butler

  • Work Package set to SasView Framework Enhancements

comment:2 Changed 19 months ago by ajj

  • Milestone changed from SasView Next Release +1 to SasView 4.0.0
  • Owner set to krzywon
  • Priority changed from major to critical
  • Status changed from new to assigned

comment:3 Changed 19 months ago by krzywon

A file specification and sample data set would be useful for this. Could someone upload or link to either/both prior to CodeCamp? IV?

comment:5 Changed 19 months ago by smk78

I don't know what the current status of NXcansas is. PeteJ and Tobias are probably best-placed to comment, though Andrew may know?

However, is any application actually generating files in this format at present? I'm not aware of any that are.

comment:6 Changed 19 months ago by ajj

Example datasets here:

https://github.com/canSAS-org/canSAS2012/tree/master/examples/contributions

Use the ones at the top level there - they are converted NG3 magnetic field series

NXCansas is basically done but I struggle with the nexus repo. Tobias is going to send round something later this month.

comment:7 Changed 15 months ago by krzywon

I have a reader that can load both 1D and 2D data sets, but only if they are in independent 'SASentry's. All SASdata objects are lumped into a single Data1D or Data2D object. I am already working on allowing for both 1D and 2D data within the same SASentry and should have that ready prior to the final 4.0 release.

comment:8 Changed 15 months ago by smk78

The 'version 0' hdf cansas file I circulated the other month provoked quite a lot of discussion in the Data Format WG and generated several tweaks to the output. These are currently being worked into Mantid. I'll put out a revised file for testing when available.

comment:9 Changed 15 months ago by smk78

The CanSAS Data Format Working Group has now 'approved' the latest version of the NXcanSAS hdf format. Examples of 1D and 2D files have been posted to https://github.com/canSAS-org/NXcanSAS_examples/tree/master/Mantid. They are the *_v3.h5 files. We should now support this format in SasView.

comment:10 Changed 15 months ago by krzywon

My latest push can read in the v3 files in 1D and 2D format. I kept a few vestiges for the previous version to be sure there is backward compatibility with any existing data sets floating around.

comment:11 Changed 14 months ago by smk78

Seems to work. Am closing the ticket.

comment:12 Changed 14 months ago by smk78

  • Resolution set to fixed
  • Status changed from assigned to closed

comment:13 Changed 14 months ago by krzywon

  • Resolution fixed deleted
  • Status changed from closed to reopened

I'm glad to hear the reader works! I'm reopening this ticket as a reminder to myself to write unit tests.

comment:14 Changed 14 months ago by krzywon

  • Resolution set to fixed
  • Status changed from reopened to closed

I refactored the Cansas HDF5 reader to allow any number of SASdata with a single SASentry and and number of SASentry within a single data file. Each SASdata object becomes its own Data1D/2D object and the reader allows for 1D and 2D data within the same SASentry.

I added two unit tests that can load in a data set with a single SASdata in a single SASentry and another that loads multiple of each.

comment:15 Changed 14 months ago by smk78

Will you be doing the same for Cansas 1D XML files with multiple SASentry and SASdata?

comment:16 Changed 14 months ago by krzywon

I'm working on it right now.

Note: See TracTickets for help on using tickets.