Opened 6 years ago

Closed 5 years ago

Last modified 4 years ago

#207 closed enhancement (duplicate)

Batch fitting does not display the correct data

Reported by: smk78 Owned by:
Priority: minor Milestone: SasView 3.1.0
Component: SasView Keywords: Batch, Fitting, Plotting
Cc: Work Package: SasView GUI Redesign

Description

This defect exists in SasView? 2.2.1 and 3.0.0.

After executing a batch fit, if you click on the data source dropdown
in the batch fit perspective SasView? shows you a fit to the datasource
selected.

The model data (the Mx calculation) appears to be correct for the
datasource selected, but the experimental data shown is not.

I think SasView? is merely showing the initially fitted datasource over
and over again but plotting the new model data, because if you
separately fit the multiple datasets you get the same fit parameters
as in the batch fit grid window (fortunately!!!) but different graphs!

In summary: batch fitting is working, and you can save the correct fit
to your datasource, but the graph SasView? shows you is misleading.

Change History (8)

comment:1 Changed 6 years ago by smk78

  • Priority changed from major to critical

Correction to the above: SasView? is not displaying/saving the correct fits to the data after batch fitting! Accordingly I am raising this defect from 'major' to 'critical'.

What is happening is that when you display a batch fitted result by clicking on the datasource dropdown you get a graph that shows experimental data and model fit. The legend correctly identifies them (ie, data[1] and M1, data[2] and M2) but this is wrong. I think the data is correct, but despite what the legend says the model is always M1 (or, at least, the first data fitted).

When you then try to save the model fit to a file the context menu correctly identifies the data you are about to save, but what you actually end up saving is M1 every time.

comment:2 Changed 6 years ago by butler

  • Milestone changed from SasView Next Release +1 to SasView 3.0.0

comment:3 Changed 5 years ago by butler

After reviewing this ticket is more about failures of documentation and quirkiness of interface than broken. The issues is that the dropdown brings up the data file plot useful in setting up the batch but after the batch has run cannot access the results of the batch — hence all manipulation of results must be done on batch fit page. However the unsuspecting user, seeing the new plot window pop up with a fit (which is just the theory curve based on the model parameters on the page) can wrongly assume the "model" line is the fit result.

Many enhancements to batch have been discussed and would be useful but not appropriate for this ticket.

ToDo for this ticket:
MINIMUM - add red warning on batch fit page that the dropdown ONLY related to the data NOT the the resulting fit.

Alternatively could also restructure "view fits" on batch page to be more obviously seperate from plotting of data columns AND provide better instructions. For example - could move to the top and/or put box around it. Longer term one would like to get the results back to the batchpage so could pop up stuff properly.

Last edited 4 years ago by butler (previous) (diff)

comment:4 Changed 5 years ago by butler

  • Priority changed from critical to minor
  • Type changed from defect to task

comment:5 Changed 5 years ago by butler

  • Type changed from task to enhancement

comment:6 Changed 5 years ago by butler

  • Milestone changed from SasView 3.0.0 to SasView Next Release +1

comment:7 Changed 5 years ago by butler

  • Resolution set to duplicate
  • Status changed from new to closed
  • Work Package set to SasView GUI Redesign

This ticket has been split into two #234 and #292. this ticket can now be closed

comment:8 Changed 4 years ago by butler

  • Milestone changed from SasView Next Release +1 to SasView 3.1.0
Note: See TracTickets for help on using tickets.