Opened 8 years ago

Closed 5 years ago

Last modified 5 years ago

#189 closed defect (fixed)

Save Project doesn't save state of simultaneous fit panel

Reported by: ajj Owned by: krzywon
Priority: critical Milestone: SasView 4.1.0
Component: SasView Keywords:
Cc: Work Package: Saving State Enhancements

Description

Having gone through the pain of setting up a simultaneous fit, that state should be saved with the project.

Change History (14)

comment:1 Changed 8 years ago by butler

  • Milestone changed from SasView 3.0.0 to WishList

Again no man-power willing to look at the save and report issues so moving to wishlist for now

comment:2 Changed 7 years ago by butler

  • Work Package set to Reporting Enhancements

comment:3 Changed 7 years ago by butler

  • Work Package changed from Reporting Enhancements to Saving State Enhancements

comment:4 Changed 6 years ago by butler

  • Milestone changed from WishList to SasView 4.0.0

comment:5 Changed 6 years ago by butler

  • Priority changed from major to critical

comment:6 Changed 5 years ago by butler

  • Milestone changed from SasView 4.0.0 to SasView Next Release +1

will need to much of a refactor to do for 4.0

comment:7 Changed 5 years ago by butler

  • Milestone changed from SasView Next Release +1 to SasView 4.1.0

comment:8 Changed 5 years ago by krzywon

  • Owner set to krzywon
  • Status changed from new to accepted

comment:9 Changed 5 years ago by krzywon

I have a working save state for the simultaneous fit panel pushed to the wx_save_simfit branch on git. I am working on loading it now.

comment:10 Changed 5 years ago by Jeff Krzywon <krzywon@…>

In e89aed5c946bf39b3cb963b0c7805341c30d2432/sasview:

#189: Can now open the simultaneous and constrained fit panel through a save state, but the constraint loading is still broken.

comment:11 Changed 5 years ago by Jeff Krzywon <krzywon@…>

In 4fea1df3346e74844ba5587f0cf0192bc0922373/sasview:

#189: Loading in all contraints now, but can have conflicts with already loaded data.

comment:12 Changed 5 years ago by krzywon

In 998ca90ad87500d7d5fb3f4eb13105752a2f2952/sasview:

#189 #12 Saving and loading project now fully saves and loads a simultaneous fits. Loading a project will reset Sasview state to its base state (with a warning). One error on load to fix before calling this finished.

comment:13 Changed 5 years ago by GitHub <noreply@…>

  • Resolution set to fixed
  • Status changed from accepted to closed

In 60df6c144a7cccfd4d8c99cedca75d5566f1c709/sasview:

Merge pull request No. 13 from SasView?/wx_save_simfit

wx Saving Simultaneous and Constrained Fitting Panel

Closes #189 & closes #12

comment:14 Changed 5 years ago by smk78

Fix verified.

Though I do note that the STATE of the model parameters is not saved; so when you re-open the project all parameters in all FitPages are unchecked by default. The only slight issue with this is that the Open Project also takes you to the Const & Simul Fit page where it is tempting to just click Fit… If you do so the Fit button turns to Stop giving you the IMPRESSION it is fitting when in fact it isn't doing a bean. The first time I did this I felt a bit of a numpty for spending a few mins sat watching SasView do absolutely nothing! :-)

Note: See TracTickets for help on using tickets.