Opened 8 months ago

Last modified 8 months ago

#1243 assigned defect

Problem reopening saved project .svs file

Reported by: smk78 Owned by: krzywon
Priority: blocker Milestone: SasView 4.2.2
Component: SasView Keywords:
Cc: Work Package: SasView Bug Fixing

Description

User Kilian Frank reports:

I have a technical issue with the "Open Project" function. I saved an .svs file 
containing a single dataset, custom model and fit with SasView 4.2.1. Now I try 
to open it on the same machine a day later with the same SasView and get the 
error message

2019-03-08 10:40:21 : DataLoader Error: Encounted Non-ASCII character ('Reader' 
object has no attribute 'sort_one_d_data')

Is there any way I can get get back my project (e.g. by manually fixing the Non-
ASCII character in the file) and what should I avoid when saving my projects in 
the future to prevent this from happening?

Attachments (3)

plate2_016_sub.svs (194.8 KB) - added by butler 8 months ago.
Offending project file
six_shells_01.py (1.7 KB) - added by butler 8 months ago.
Python part of model used in project file
six_shells_01.c (5.0 KB) - added by butler 8 months ago.
c part of model used in project file

Download all attachments as: .zip

Change History (10)

comment:1 Changed 8 months ago by smk78

  • Owner set to krzywon
  • Status changed from new to assigned

comment:2 Changed 8 months ago by smk78

Update:

There were no non-UTF8 characters in the filenames, only underscores.

File path is:

/IRP/AG_Salditt/Messzeiten/2018/extern/ESRF_SC4755_ID02/Analysis/Kilian/PLs_fusion/
anisotropic_fits/22_six_shell_model_SasView/plate2_016_sub.svs

comment:3 Changed 8 months ago by smk78

@butlerpd has the offending project file.

Changed 8 months ago by butler

Offending project file

Changed 8 months ago by butler

Python part of model used in project file

Changed 8 months ago by butler

c part of model used in project file

comment:4 Changed 8 months ago by butler

I will attache the file and model files. I can confirm that I got the same error when trying to read the .svs file. The xml looks straigthforward to me. User should be able to recover the parameters they used fairly easily manually - but the question is why did it happen?

comment:5 Changed 8 months ago by krzywon

The changes made to the NXcanSAS reader included a method name change, but the old method name was still in use when loading project files that slipped through. This will be an issue for anyone attempting to load projects and might need a quick point release.

I already have a working solution on my local machine, but how should I proceed, now that quite a few PRs have been merged into master? Branch off the 4.2.1 tag and submit a fix from there?

This really highlights the need for a save/load project unit test suite for 4.x (ticket #839).

comment:6 Changed 8 months ago by Jeff Krzywon <jkrzywon@…>

In 2b3eb3dacf42149909e5d221a9f6ad7d6b647c31/sasview:

Use new combined method when loading in project files. refs #1243

comment:7 Changed 8 months ago by butler

  • Milestone changed from SasView 4.3.0 to SasView 4.2.2
Note: See TracTickets for help on using tickets.