Opened 3 years ago

Closed 3 years ago

#1223 closed enhancement (fixed)

Expand permitted range of transformed data in Corfunc implementation

Reported by: smk78 Owned by: awashington
Priority: blocker Milestone: SasView 4.2.1
Component: SasView Keywords:
Cc: Work Package: SasView GUI Enhancements

Description

User Sam Welborn (UPenn) notes that at present the correlation function analysis doesn't permit the viewing or output of the transforms beyond x=200 Ang, which implies you have no features-of-interest in the scattering at Q<0.032 Ang-1. This limit was inherited from the original Corfunc program and suited the requirements (and computational resources at the time) of those that developed it. But with hindsight it now restricts the applicability and usefulness of this functionality in SasView. Sam's data (attached) has a feature at ~600 Ang, for example.

I suggest a two-step approach:

1) Raise the hard=coded output limit to 1000 Ang: as this should be trivial I've made it a blocker for the 4.2.1 release;

2) In SasView 5, consider adding editable input boxes to the correlation function GUIs to allow the user to define the transform limit (currently set to 100 x Qmax) and the display range discussed above.

Attachments (1)

for_horizons_real.txt (106.6 KB) - added by smk78 3 years ago.
Example data from Sam Welborn

Download all attachments as: .zip

Change History (7)

Changed 3 years ago by smk78

Example data from Sam Welborn

comment:1 Changed 3 years ago by butler

I have never looked at this part of the code base, but assume that by trivial is meant a single line edit? though I guess it will need testing? One question however: Are we sure the limit is due to computational/use case needs and that there is no inherent limitation of the method or maths that invalidates it beyond a certain length scale?

comment:2 Changed 3 years ago by smk78

I believe that it is straightforward, though it would be good to get Adam's take.

I'm not aware of any inherent limitation, at least, not at the length scales we are talking about here. The Qmax/Xmin end has a limit, of course, which is technically infinity and zero respectively, but which for practical purposes is limited to be a typical bond length. But going the other way…

comment:3 Changed 3 years ago by awashington

I've submitted pr 204, which increases the bounds to a micron (640k out to be enough for anybody). We'll still need to make this customizable in version 5.0, but there's no reason to start changing the wx gui this late in the game, especially on a minor point release.

comment:4 Changed 3 years ago by smk78

Cloned branch, built and tested on W64. Does what it says on the tin! Closes #1223

comment:5 Changed 3 years ago by smk78

  • Owner set to awashington
  • Status changed from new to assigned

comment:6 Changed 3 years ago by smk78

  • Resolution set to fixed
  • Status changed from assigned to closed
Note: See TracTickets for help on using tickets.