Opened 12 months ago

Closed 12 months ago

Last modified 7 months ago

#1127 closed defect (duplicate)

File Loader is not loading valid NXcanSAS

Reported by: smk78 Owned by:
Priority: critical Milestone: SasView 4.2.1
Component: SasView Keywords:
Cc: Work Package: SasView Bug Fixing

Description

Jan Ilvasky/Pete Jemian have noted several issues with how SasView handles NXcanSAS:

i) SasView expects NXcanSAS to have the .h5 extension, however such enforcement actually breaks the NeXus standard which doesn't specify an extension (Tim Snow notes that .h5, .nxs, .nexus, .hdf, even .nx.hdf are in use!);

ii) the .h5 example files in the SasView /test folder are actually incompatible with the NXcanSAS standard, they use the attributes “uncertainty” and “I_uncertainty" instead of the plural “uncertainties”.

Separately, Brian Pauw would like SasView to start loading NXcanSAS containing @Mask_indicies

Change History (3)

comment:1 Changed 12 months ago by butler

Actually this looks like a slight extension to #976? Can we move this info there and close this duplicate ticket? Or bring the other info and close the old as duplicate?

The bottom line is we know that we are in fact not fully compliant with the NXcanSAS standard and need to fix that…. but we cannot necessarily use all the things that a specific NXcanSAS file gives us. What the reader should do is accept any NXcanSAS standard compliant file that contains the information needed by SasView. This means:

  • Check for an NXcanSAS format beyond its extension (as required by the spec)
  • Read all the SasView relevant information as long as it is provided in a way that conforms to the standard — meaning we must look at the attribute tags first
  • In the absence of an attribute tag we should look for common names we expect (but this is an extra so don't need to guess everybody's naming)
  • accept any file we can extract the appropriate information from even if it contains a lot of extra guff we don't understand (said guf being discarded by SasView)

comment:2 Changed 12 months ago by smk78

  • Resolution set to duplicate
  • Status changed from new to closed

Ahh. My bad. I searched on NXcanSAS to check for other tickets but #976 is titled CanSAS HDF!

Ok. Closing this ticket and updating #976.

comment:3 Changed 7 months ago by butler

  • Milestone changed from SasView 4.3.0 to SasView 4.2.1

This is tied to ticket #976 so should be listed under 4.2.1 - now moving

Note: See TracTickets for help on using tickets.