Opened 6 years ago

Closed 6 years ago

#1111 closed defect (fixed)

Convert all input Q units to 1/A

Reported by: krzywon Owned by: krzywon
Priority: major Milestone: SasView 4.2.1
Component: SasView Keywords:
Cc: Work Package: SasView Bug Fixing

Description

All loaded data sets should convert the Q units to 1/A (or A for SESANS data) to be sure the returned fitting parameters are correct.

A unit conversion method already exists in the canSAS XML reader. Moving the converter to the file_reader_base_class and sending all final Q arrays to it should be fairly straightforward.

Change History (4)

comment:1 Changed 6 years ago by krzywon

  • Owner set to krzywon
  • Status changed from new to assigned

comment:2 Changed 6 years ago by krzywon

In 3bab401d91e365ff93f8efbf5368655767ff2e5f/sasview:

Create a universal unit converter for all data loaders. refs #1111

comment:3 Changed 6 years ago by krzywon

  • Milestone changed from SasView 4.3.0 to SasView 4.2.1

A fix for this is already included with ​PR180 for the NXcanSAS reader. Moving up to 4.2.1.

comment:4 Changed 6 years ago by GitHub <noreply@…>

  • Resolution set to fixed
  • Status changed from assigned to closed

In dcd6efda873ff0f7f10cbe8d301cc4cc3f65cd3b/sasview:

Merge pull request #180 from SasView?/ticket-1111

Multiple data loader and writer updates - NXcanSAS compliance, data conversion, saving as NXcanSAS, plus more

Fixes #976
Fixes #1129
Fixes #1111
Fixes #1221

Note: See TracTickets for help on using tickets.