Opened 18 months ago

Closed 7 months ago

#1046 closed task (wontfix)

convert non builtin models in the marketplace to new API

Reported by: butler Owned by: butler
Priority: critical Milestone: SasView 4.2.0
Component: sasmodels Markeplace Keywords:
Cc: Work Package: SasModels Redesign


SasView 4.2 changes completely how orientation is done and the API to the sasmodels interface thus changes so that all old models will fail. This is a problem for plugins, including anything downloaded from the marketplace. The solution is twofold:

  • First, in ticket #1043, sasmodels needs to recognize old models and ignore the 2D (maintaining backward compatibility is way too hard and has a number of other issues that make it not worth doing). This should allow all old plugins that were used for 1D to continue to work.
  • The second part is this ticket and is to convert the few custom models currently uploaded to the marketplace that have real 2D code to use the new API. Also, as per ticket #1045, we should change the name slightly so as to keep both versions on the marketplace with a note in the documentation for now indicating the version difference.

Change History (5)

comment:1 Changed 18 months ago by butler

  • Component changed from SasView to sasmodels Markeplace
  • Work Package changed from SasView Bug Fixing to SasModels Redesign

comment:2 Changed 16 months ago by butler

  • Owner set to butler
  • Status changed from new to assigned

comment:3 Changed 14 months ago by butler

  • Priority changed from critical to major

comment:4 Changed 8 months ago by butler

  • Priority changed from major to critical

At this point all remaining tickets should either be blockers or critical. Critical would be those that do not stop the actual release but need to be dealt with soon after such as updating the marketplace. Tickets such as this are blockers in that if not fixed the docs need to have an appropriate warning in them for this release. Once that is fixed the ticket moves to 4.3 if it is not closed.

comment:5 Changed 7 months ago by butler

  • Resolution set to wontfix
  • Status changed from assigned to closed

After some discussion, it is clear that the remaining portion of this ticket is ill advised. Changing user uploaded models out from under them, while could be helpful to making their models stay up to date, would also preclude the ability to use this as a repository of the actual model they used in a paper. The zenodo doi does not include their custom code (but does include the built in model code). This just reinforces the need to refactor the marketplace to provide the SasView versions a model is compatible with.

As agreed on the last fortnightly call this ticket is therefore being closed as won't fix

Note: See TracTickets for help on using tickets.