Opened 7 years ago

Closed 6 years ago

#1008 closed defect (fixed)

plugin model scaling not working?

Reported by: richardh Owned by: richardh
Priority: blocker Milestone: SasView 4.2.0
Component: SasView Keywords:
Cc: Work Package: SasView Bug Fixing


In my local build of current (5th Oct, 2017) "master" of 4.1.2

I have a plugin version of the same model that I have in the normal place, if I for example fit only the scale and background the fitted values are WRONG for the plugin version.

Also for the plugin version the plot is not being updated unless I do "compute" after "fit".

(Yes I have renamed the .c and .py files for the plugin version of core_shell_bicelle_elliptical so there should not be a conflict of names.)

As I am trying to write a new plugin model to give to a user, this is rather worrying. Has anyone else seen similar?

Change History (5)

comment:1 Changed 7 years ago by butler

There seem to be some issues with the models interface in general (see #1006 and #1007) but have not heard of this one yet. However regarding name space I think you also have to change the name string in the python file

name = "new_name"

comment:2 Changed 7 years ago by richardh

Yes, I did that too.

comment:3 Changed 6 years ago by smk78

Possibly related? Steve Parnell was using 4.1.2 to fit a plugin and spotted some odd behaviour that I could replicate:

I just created a mass fractal + dab plugin and tried fitting a couple of data sets from the test folder. It does seem to work, but the first time you click fit it updates the parameters but NOT the plot. To make the plot update that first time you need to click compute. Thereafter the plot moves with the fit button. This, I concede, would appear to be a bug.

comment:4 Changed 6 years ago by mathieu

I could not reproduce this. The only odd behavior I saw was that if I fit the same data set in two fitting tabs, only the plot from the last tab I created is updated.

To test this, I copied the model into my plug-in directory and fit a single data using both models (the original and the plug-in versions). I got the same results in both cases.

comment:5 Changed 6 years ago by richardh

  • Resolution set to fixed
  • Status changed from new to closed

As with Mathieu last week, I cannot now reproduce the original bug, the plugin and built in models give the same fit results as expected.

Will close this ticket as no-one else has seen issues.

Note: See TracTickets for help on using tickets.