Opened 13 months ago

Last modified 3 weeks ago

#1004 assigned defect

better defaults for magnetic sld

Reported by: pkienzle Owned by: butler
Priority: minor Milestone: SasView 4.3.0
Component: SasView Keywords:
Cc: Work Package: SasView Bug Fixing

Description (last modified by butler)

When turning on magnetism, the default magnetic sld is set to 1e-6. This should default to 1 instead.

When turning off magetism and turning it on again, the defaults are reset.

NOTE
The rest of this ticket related to failure to compute is moved to #1083

Change History (9)

comment:1 Changed 8 months ago by butler

  • Owner set to butler
  • Status changed from new to assigned

comment:2 Changed 8 months ago by butler

  • Priority changed from major to critical

comment:3 Changed 7 months ago by ajj

  • Priority changed from critical to blocker

comment:4 Changed 7 months ago by butler

  • Description modified (diff)
  • Priority changed from blocker to minor

comment:5 Changed 4 months ago by butler

  • Milestone changed from SasView 4.2.0 to SasView 4.3.0

probably not going to make it for this release so moving to 4.3

comment:6 Changed 3 weeks ago by Paul Kienzle <pkienzle@…>

In cf1be88859d17b4a94fd7aa3d1d4161f6bad4bc3/sasview:

remove e-06 from default magnetism values. Refs #1004

comment:7 Changed 3 weeks ago by pkienzle

There is a PR for addressing the order of magnitude portion of the ticket.

To address the main point of the ticket (that the values return the defaults when magnetism is toggled off and on), need to add a flag to the sasmodels wrapper that determines whether magnetism should be enabled for the calculation, and ignore the magnetic parameters otherwise. Then don't modify _on_mag_on() method in basepage.py within sasview so that it sets/resets this flag rather than setting/resetting the magnetic slds all to zero.

comment:8 Changed 3 weeks ago by Piotr Rozyczko <piotr.rozyczko@…

In 5323490d62009a786d3d071b2197b51ce207354d/sasview:

remove e-06 from default magnetism values. Refs #1004 (#188)

comment:9 Changed 3 weeks ago by GitHub <noreply@…>

In 23ff8d59c4fa1e2d5cc538eee7fbb8c4e66cb82d/sasview:

Revert "remove e-06 from default magnetism values. Refs #1004 (#188)"

This reverts commit 5323490d62009a786d3d071b2197b51ce207354d.

Note: See TracTickets for help on using tickets.