Changeset 8c9e65c in sasview for src/sas/sascalc/calculator

Timestamp:

Mar 5, 2019 1:52:24 PM (6 years ago)

Author:

GitHub <noreply@…>

Branches:

master, magnetic_scatt, release-4.2.2, ticket-1009, ticket-1094-headless, ticket-1242-2d-resolution, ticket-1249

Children:

f205d3a, 1342f6a

Parents:

0a924c6 (diff), 4cbb2f5 (diff)
Note: this is a merge changeset, the changes displayed below correspond to the merge itself.
Use the (diff) links above to see all the changes relative to each parent.

git-author:

Paul Kienzle <pkienzle@…> (03/05/19 13:52:24)

git-committer:

GitHub <noreply@…> (03/05/19 13:52:24)

Message:

py37 support for sascalc. Refs #888 an #1233.

Location:

src/sas/sascalc/calculator

Files:

• instrument.py (modified) (1 diff)
• resolution_calculator.py (modified) (2 diffs)
• c_extensions/__init__.py (deleted)
• c_extensions/sld2i_module.c (modified) (6 diffs)
• sas_gen.py (modified) (5 diffs)

src/sas/sascalc/calculator/instrument.py

@@ -128 +128 @@
             self.size = 0
         else:
-            self.size = size
+            # TODO: Make sure detector size is number of pixels
+            # Could be detector dimensions in e.g., mm, but
+            # the resolution calculator assumes it is pixels.
+            # Being pixels, it has to be integers rather than float
+            self.size = [int(s) for s in size]
             validate(size[0])
 

src/sas/sascalc/calculator/resolution_calculator.py

@@ -1007 +1007 @@
         try:
             detector_offset = self.sample2detector_distance[1]
-        except:
-            logger.error(sys.exc_value)
+        except Exception as exc:
+            logger.error(exc)
 
         # detector size in [no of pix_x,no of pix_y]
@@ -1094 +1094 @@
             output.qx_data = qx_value
             output.qy_data = qy_value
-        except:
-            logger.error(sys.exc_value)
+        except Exception as exc:
+            logger.error(exc)
 
         return output

src/sas/sascalc/calculator/c_extensions/sld2i_module.c

@@ -2 +2 @@
   SLD2I module to perform point and I calculations
  */
+#include <stdio.h>
+
+//#define Py_LIMITED_API 0x03020000
 #include <Python.h>
-#include <stdio.h>
+
 #include "sld2i.h"
 
@@ -13 +16 @@
 #endif
 
-
-// Utilities
-#define INVECTOR(obj,buf,len)                                                                           \
-    do { \
-        int err = PyObject_AsReadBuffer(obj, (const void **)(&buf), &len); \
-        if (err < 0) return NULL; \
-        len /= sizeof(*buf); \
-    } while (0)
-
-#define OUTVECTOR(obj,buf,len) \
-    do { \
-        int err = PyObject_AsWriteBuffer(obj, (void **)(&buf), &len); \
-        if (err < 0) return NULL; \
-        len /= sizeof(*buf); \
-    } while (0)
-
+// Vector binding glue
+#if (PY_VERSION_HEX > 0x03000000) && !defined(Py_LIMITED_API)
+  // Assuming that a view into a writable vector points to a 
+  // non-changing pointer for the duration of the C call, capture 
+  // the view pointer and immediately free the view.
+  #define VECTOR(VEC_obj, VEC_buf, VEC_len) do { \
+    Py_buffer VEC_view; \
+    int VEC_err = PyObject_GetBuffer(VEC_obj, &VEC_view, PyBUF_WRITABLE|PyBUF_FORMAT); \
+    if (VEC_err < 0 || sizeof(*VEC_buf) != VEC_view.itemsize) return NULL; \
+    VEC_buf = (typeof(VEC_buf))VEC_view.buf; \
+    VEC_len = VEC_view.len/sizeof(*VEC_buf); \
+    PyBuffer_Release(&VEC_view); \
+  } while (0)
+#else
+  #define VECTOR(VEC_obj, VEC_buf, VEC_len) do { \
+    int VEC_err = PyObject_AsWriteBuffer(VEC_obj, (void **)(&VEC_buf), &VEC_len); \
+    if (VEC_err < 0) return NULL; \
+    VEC_len /= sizeof(*VEC_buf); \
+  } while (0)
+#endif
 
 /**
@@ -73 +80 @@
         //printf("new GenI\n");
         if (!PyArg_ParseTuple(args, "iOOOOOOOOddd", &is_avg, &x_val_obj, &y_val_obj, &z_val_obj, &sldn_val_obj, &mx_val_obj, &my_val_obj, &mz_val_obj, &vol_pix_obj, &inspin, &outspin, &stheta)) return NULL;
-        INVECTOR(x_val_obj, x_val, n_x);
-        INVECTOR(y_val_obj, y_val, n_y);
-        INVECTOR(z_val_obj, z_val, n_z);
-        INVECTOR(sldn_val_obj, sldn_val, n_sld);
-        INVECTOR(mx_val_obj, mx_val, n_mx);
-        INVECTOR(my_val_obj, my_val, n_my);
-        INVECTOR(mz_val_obj, mz_val, n_mz);
-        INVECTOR(vol_pix_obj, vol_pix, n_vol_pix);
+        VECTOR(x_val_obj, x_val, n_x);
+        VECTOR(y_val_obj, y_val, n_y);
+        VECTOR(z_val_obj, z_val, n_z);
+        VECTOR(sldn_val_obj, sldn_val, n_sld);
+        VECTOR(mx_val_obj, mx_val, n_mx);
+        VECTOR(my_val_obj, my_val, n_my);
+        VECTOR(mz_val_obj, mz_val, n_mz);
+        VECTOR(vol_pix_obj, vol_pix, n_vol_pix);
         sld2i = PyMem_Malloc(sizeof(GenI));
         //printf("sldi:%p\n", sld2i);
@@ -108 +115 @@
         if (!PyArg_ParseTuple(args, "OOOO",  &gen_obj, &qx_obj, &qy_obj, &I_out_obj)) return NULL;
         sld2i = (GenI *)PyCapsule_GetPointer(gen_obj, "GenI");
-        INVECTOR(qx_obj, qx, n_qx);
-        INVECTOR(qy_obj, qy, n_qy);
-        OUTVECTOR(I_out_obj, I_out, n_out);
+        VECTOR(qx_obj, qx, n_qx);
+        VECTOR(qy_obj, qy, n_qy);
+        VECTOR(I_out_obj, I_out, n_out);
         //printf("qx, qy, I_out: %d %d %d, %d %d %d\n", qx, qy, I_out, n_qx, n_qy, n_out);
 
@@ -136 +143 @@
         if (!PyArg_ParseTuple(args, "OOO",  &gen_obj, &q_obj, &I_out_obj)) return NULL;
         sld2i = (GenI *)PyCapsule_GetPointer(gen_obj, "GenI");
-        INVECTOR(q_obj, q, n_q);
-        OUTVECTOR(I_out_obj, I_out, n_out);
+        VECTOR(q_obj, q, n_q);
+        VECTOR(I_out_obj, I_out, n_out);
 
         // Sanity check
@@ -160 +167 @@
 
 #define MODULE_DOC "Sld2i C Library"
-#define MODULE_NAME "sld2i"
-#define MODULE_INIT2 initsld2i
-#define MODULE_INIT3 PyInit_sld2i
+#define MODULE_NAME "_sld2i"
+#define MODULE_INIT2 init_sld2i
+#define MODULE_INIT3 PyInit__sld2i
 #define MODULE_METHODS module_methods
 

src/sas/sascalc/calculator/sas_gen.py

@@ -14 +14 @@
 import numpy as np
 
-from .core import sld2i as mod
+from . import _sld2i
 from .BaseComponent import BaseComponent
 
@@ -145 +145 @@
             self.params['Up_frac_out'],
             self.params['Up_theta'])
-        model = mod.new_GenI(*args)
+        model = _sld2i.new_GenI(*args)
         if len(qy):
             qx, qy = _vec(qx), _vec(qy)
             I_out = np.empty_like(qx)
             #print("npoints", qx.shape, "npixels", pos_x.shape)
-            mod.genicomXY(model, qx, qy, I_out)
+            _sld2i.genicomXY(model, qx, qy, I_out)
             #print("I_out after", I_out)
         else:
             qx = _vec(qx)
             I_out = np.empty_like(qx)
-            mod.genicom(model, qx, I_out)
+            _sld2i.genicom(model, qx, I_out)
         vol_correction = self.data_total_volume / self.params['total_volume']
         result = (self.params['scale'] * vol_correction * I_out
@@ -304 +304 @@
                 z_dir2 *= z_dir2
                 mask = (x_dir2 + y_dir2 + z_dir2) <= 1.0
-            except Exception:
-                logger.error(sys.exc_value)
+            except Exception as exc:
+                logger.error(exc)
         self.output = MagSLD(self.pos_x[mask], self.pos_y[mask],
                              self.pos_z[mask], self.sld_n[mask],
@@ -600 +600 @@
                         y_lines.append(y_line)
                         z_lines.append(z_line)
-                except Exception:
-                    logger.error(sys.exc_value)
+                except Exception as exc:
+                    logger.error(exc)
 
             output = MagSLD(pos_x, pos_y, pos_z, sld_n, sld_mx, sld_my, sld_mz)
@@ -691 +691 @@
                             _vol_pix = float(toks[7])
                             vol_pix = np.append(vol_pix, _vol_pix)
-                        except Exception:
+                        except Exception as exc:
                             vol_pix = None
-                    except Exception:
+                    except Exception as exc:
                         # Skip non-data lines
-                        logger.error(sys.exc_value)
+                        logger.error(exc)
             output = MagSLD(pos_x, pos_y, pos_z, sld_n,
                             sld_mx, sld_my, sld_mz)