Changeset 722b7d6 in sasview for src/sas/qtgui/MainWindow/DataExplorer.py

Timestamp:

Oct 29, 2018 4:34:53 AM (6 years ago)

Author:

piotr

Branches:

ESS_GUI, ESS_GUI_batch_fitting, ESS_GUI_bumps_abstraction, ESS_GUI_iss1116, ESS_GUI_opencl, ESS_GUI_ordering, ESS_GUI_sync_sascalc

Children:

ec4a143

Parents:

75906a1

Message:

Minor changes after PK's CR + minor refactoring.

File:

• src/sas/qtgui/MainWindow/DataExplorer.py (modified) (3 diffs)

src/sas/qtgui/MainWindow/DataExplorer.py

@@ -364 +364 @@
         pass
 
-    def sendData(self, event):
+    def sendData(self, event=None):
         """
         Send selected item data to the current perspective and set the relevant notifiers
@@ -1171 +1171 @@
         Mask Editor for 2D plots
         """
+        msg = QtWidgets.QMessageBox()
+        msg.setIcon(QtWidgets.QMessageBox.Information)
+        msg.setText("Error: cannot apply mask.\n"+
+                    "Please select a 2D dataset.")
+        msg.setStandardButtons(QtWidgets.QMessageBox.Ok)
+
         try:
             if data is None or not isinstance(data, Data2D):
+                # if data wasn't passed - try to get it from
+                # the currently selected item
                 index = self.current_view.selectedIndexes()[0]
                 proxy = self.current_view.model()
@@ -1181 +1189 @@
 
             if data is None or not isinstance(data, Data2D):
-                msg = QtWidgets.QMessageBox()
-                msg.setIcon(QtWidgets.QMessageBox.Information)
-                msg.setText("Error: cannot apply mask. \
-                                Please select a 2D dataset.")
-                msg.setStandardButtons(QtWidgets.QMessageBox.Cancel)
+                # If data is still not right, complain
                 msg.exec_()
                 return
         except:
-            msg = QtWidgets.QMessageBox()
-            msg.setIcon(QtWidgets.QMessageBox.Information)
-            msg.setText("Error: No dataset selected. \
-                            Please select a 2D dataset.")
-            msg.setStandardButtons(QtWidgets.QMessageBox.Cancel)
             msg.exec_()
             return