Changeset 300a2f7 in sasmodels

Timestamp:

Aug 18, 2016 11:30:23 AM (8 years ago)

Author:

Paul Kienzle <pkienzle@…>

Branches:

master, core_shell_microgels, costrafo411, magnetic_model, release_v0.94, release_v0.95, ticket-1257-vesicle-product, ticket_1156, ticket_1265_superball, ticket_822_more_unit_tests

Children:

4f3dd42

Parents:

6dc78e4

Message:

Force programs to be recompiled on OpenCL when they are changed. Ref #576

Location:

sasmodels

Files:

• kernelcl.py (modified) (4 diffs)
• sasview_model.py (modified) (1 diff)

sasmodels/kernelcl.py

@@ -281 +281 @@
             warnings.warn("the environment variable 'PYOPENCL_CTX' might not be set correctly")
 
-    def compile_program(self, name, source, dtype, fast=False):
-        # type: (str, str, np.dtype, bool) -> cl.Program
+    def compile_program(self, name, source, dtype, fast, timestamp):
+        # type: (str, str, np.dtype, bool, float) -> cl.Program
         """
         Compile the program for the device in the given context.
         """
+        # Note: PyOpenCL caches based on md5 hash of source, options and device
+        # so we don't really need to cache things for ourselves.  I'll do so
+        # anyway just to save some data munging time.
         key = "%s-%s%s"%(name, dtype, ("-fast" if fast else ""))
+        # Check timestamp on program
+        program, program_timestamp = self.compiled.get(key, (None, np.inf))
+        if program_timestamp < timestamp:
+            del self.compiled[key]
         if key not in self.compiled:
             context = self.get_context(dtype)
@@ -293 +300 @@
             program = compile_model(self.get_context(dtype),
                                     str(source), dtype, fast)
-            self.compiled[key] = program
-        return self.compiled[key]
-
-    def release_program(self, name):
-        # type: (str) -> None
-        """
-        Free memory associated with the program on the device.
-        """
-        if name in self.compiled:
-            self.compiled[name].release()
-            del self.compiled[name]
+            self.compiled[key] = (program, timestamp)
+        return program
 
 def _get_default_context():
@@ -399 +397 @@
         if self.program is None:
             compile_program = environment().compile_program
+            timestamp = generate.timestamp(self.info)
             self.program = compile_program(
                 self.info.name,
                 self.source['opencl'],
                 self.dtype,
-                self.fast)
+                self.fast,
+                timestamp)
             variants = ['Iq', 'Iqxy', 'Imagnetic']
             names = [generate.kernel_name(self.info, k) for k in variants]
@@ -421 +421 @@
         """
         if self.program is not None:
-            environment().release_program(self.info.name)
             self.program = None
 

sasmodels/sasview_model.py

@@ -115 +115 @@
     Load a custom model given the model path.
     """
+    #print("load custom", path)
     kernel_module = custom.load_custom_kernel_module(path)
     try: