| | 8 | 1. “report” button does nothing (nor for Steve King on build 83) |
| | 9 | |
| | 10 | 2. The very nice help documentation works fine for me (apart from the previously mentioned irritating lack of “back” button on screen, though there is one if you right click, or use ALT/leftArrow; whilst ALT/rightArrow is forward.). However the section on the optimizers is not rendering equations so has $n$, $1-sigma$ etc. |
| | 11 | |
| | 12 | 3. I think, from experiment with data rather than looking at the code, the docs for the Hayter MSA structure factor needs to note that even if no salt has been specifically added to the sample, the “salt conc” may need to be non-zero to allow for counterions that have come off say a micelle as it charges up. One day I will code up a version of the Hayter MSA where the Debye length is explicitly entered. |
| | 13 | |
| | 14 | 4. the “help about” box does not report the exact build number, just has 1 |
| | 15 | |
| | 16 | 5. why are the parameter errors now appearing in red? (Which we usually keep around here for “fault” messages, so is giving me unnecessary stress.) |
| | 17 | |
| | 18 | 6. If I set up 3 data sets with constraints, say have M2.radius=M1.radius, M3.radius=M1.radius but then fix M1.radius at say 30 ang, I would expect the constraints to still work, but I get error message on hitting Fit in constraints page. |
| | 19 | |
| | 20 | Traceback (most recent call last): |
| | 21 | File "sas\perspectives\fitting\fit_thread.pyc", line 82, in compute |
| | 22 | File "sas\perspectives\fitting\fit_thread.pyc", line 14, in map_apply |
| | 23 | File "sas\perspectives\fitting\fit_thread.pyc", line 11, in map_getattr |
| | 24 | File "sas\fit\BumpsFitting.pyc", line 262, in fit |
| | 25 | File "sas\fit\BumpsFitting.pyc", line 345, in run_bumps |
| | 26 | File "bumps\fitters.pyc", line 859, in stderr |
| | 27 | File "bumps\lsqerror.pyc", line 79, in hessian |
| | 28 | File "bumps\numdifftools.pyc", line 1159, in __call__ |
| | 29 | File "bumps\numdifftools.pyc", line 1170, in hessian |
| | 30 | File "bumps\numdifftools.pyc", line 1084, in hessdiag |
| | 31 | File "bumps\numdifftools.pyc", line 720, in _partial_der |
| | 32 | File "bumps\numdifftools.pyc", line 424, in _derivative |
| | 33 | File "bumps\numdifftools.pyc", line 686, in _romb_extrap |
| | 34 | ValueError: operands could not be broadcast together with shapes (24,) (0,) |
| | 35 | |
| | 36 | None |
| | 37 | |
| | 38 | OK the work around for this is to also fix M2.radius etc manually. However if I do that and then hit Fit on constraints page, nothing happens not even an error message. So if I “Remove” the constraints on M2.radius and M3.radius, “Fit” now attempts to work but comes back with same error message as above in red, presumably because it now has an issue with radius.width which is still constrained and fitting. Indeed if I remove the constraints on radius.width the fit now works, but with independent values for the polydispersity. |
| | 39 | |
| | 40 | I would expect the constraints to work regardless of whether the base parameters in them are fixed or adjusting. |
| | 41 | |
| | 42 | Meanwhile perhaps there can be a quick fix in this release to put up a message that “constrained parameters must all be adjusting” ? |
| | 43 | |
| | 44 | If anyone wants a simple 3 contrast core/shell microemulsion project, with real SANS data, to test the above just ask. I am grateful that “Save project” does now actually save all 3 data sets and models. (It would be nice if it also remembered which parameters are on/off, and in the +1 release, saved the constraints also, so that a fully working project could be emailed to someone else, as setting up the constraints etc is still non-trivial.) |
| | 45 | |
| | 46 | 7. In Model Documentation, the Table of contents on left side has repeats of sections 2.2, 2.3 and 2.4. (There is also a note at top of screen about proof reading, which is no doubt still true!) |
| | 47 | |
| | 48 | 8. The customised functions section of this section could do with a pointer to more docs on custom models hiding in User documentation/fitting perspective/fitting data/adding your own models |
| | 49 | |
| | 50 | 9. Might be useful if the “fit option” type was display on screen somewhere. |
| | 51 | |
| | 52 | 10. though there may be some good underlying reason, can we do away with the top level menu of the documentation? Model documentation is duplicated in User documentation, so just put Developer documentation at the bottom of the main menu and save clicks for everyone except developers (who get one more). |
| | 53 | |
| | 54 | 11. A “compute” button on the “const & simul fit” tab for a forward calculation only but with all the constraints applied would be useful. |
| | 55 | |
| | 56 | 12. In the DREAM parameter 2d correlation plots are very good but don’t actually quantify how large the correlation is. It might be useful to have some scale markers on the axes. The 2d plots are of course very small, so normal axis labels would likely look a mess, perhaps try sticks on the sides at 0 and say +-3sigma. (Normal correlation coefficients as I recall say how many standard deviations parameter A moves if parameter B moves one standard deviation.) |
