Opened 8 years ago

Last modified 7 years ago

#962 closed defect

star polymer typo in docs — at Version 2

Reported by: richardh Owned by: richardh
Priority: blocker Milestone: SasView 4.2.0
Component: sasmodels Keywords:
Cc: Work Package: SasView Bug Fixing

Description (last modified by butler)

Simple fix, but I cannot build the docs at present on windows, see #956, and needs new branch for minor changes to docs. So I am putting in this ticket to remind us to do it.

==========================================
Dear Ziang,
I am not sure if anyone has replied to you previously, if not then apologies we usually respond very quickly.
Thank you for pointing out the typo in the star polymer model documentation. It seems that I was the last person to check this model, so the team can blame me for not noticing. The correction to this will take some while to filter down into a release version of sasview. Personally I would also like to change the fitting parameter in the model from (Rg)2 to just Rg (see #552 ) which would be more logical, but there is some history here.
Thank you again,
Richard Heenan

From: Ziang Li lixx3067@…
Sent: 21 April 2017 17:19
To: help@…
Subject: [Sasview-help] SASView starpolymer model fit typo

Dear Sir/Madam:

I'm a graduate student from the university of Minnesota and have been using the SASView software for my SAXS data fitting.

I found a typo in the "help" section of the star polymer model (shape-independent), I think v should equal to u*f/(3f-2) instead of u2*f/(3f-2) since u is already defined as u=q2*Rg2 in the line below. I think it's just a typo in the "help" but it might be worth checking if the code is built according to correct form factor. Thank you!

Best,
Ziang


Ziang Li
PhD Candidate
Bates and Lodge Research Groups
Department of Chemical Engineering and Materials Science
University of Minnesota

Change History (2)

comment:1 Changed 8 years ago by richardh

Further comments from user: I looked into the code in the "star_polymer.c" file and I think the radius2 defined in the code is actually the Rg2 of the entire star polymer rather than the Rg2 of a single arm after checking against a related paper (Eqns 1 and 2, Richter, D., et al. "A study of single-arm relaxation in a polystyrene star polymer by neutron spin echo spectroscopy." Macromolecules 22.1 (1989): 468-472.).

I think the code is consistent with the paper except in the "help" section, the Rg2 should be described as the one of the star polymer if the "rg_squared" spilt out in the "Model Parameters" of the software interface is the "double radius2" in the code. Please let me your thoughts after checking. Thank you!

comment:2 Changed 8 years ago by butler

  • Description modified (diff)
Note: See TracTickets for help on using tickets.