Changes between Initial Version and Version 1 of Ticket #786, comment 2


Ignore:
Timestamp:
Mar 19, 2017 11:00:12 PM (7 years ago)
Author:
butler
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #786, comment 2

    initial v1  
    1 OK ... so it turns out that this model was indeed originally written by Divya Singh as part of her thesis (appropriate appendix attached here) in 2008.  It was reviewed and "approved" by Andrew Jackson for distribution in NIST IGOR macros in 2009.  Looking at the code it seems several original bits that were wrong are commented out and replaced (presumably by Andrew)? more importantly, there is a comment at the beginning and next to several commented out sections that the current version does NOT support a shell in C. 
     1OK ... so it turns out that this model was indeed originally written by Divya Singh as part of her thesis (appropriate appendix attached here) in 2008.  It was reviewed and "approved" by Andrew Jackson for distribution in NIST IGOR macros in 2009.  Looking at the code it seems several original bits that were wrong are commented out and replaced (presumably by Andrew)? more importantly, there is a comment at the beginning and next to several commented out sections that the current version does NOT support a shell in C. This explains the observed behavior reported in this ticket. 
    22 
    33Miguel converted the code to the sasmodels framework and noted a number of oddities and commented the code but felt he did not understand the math enough to change it.  Looking at it more closely I believe that in fact there must be an error in the normalization to units of length_b at least, and possibly a few other places.