Check default value of cansas_version property in CansasReader class

[smk78]

(Ticket raised on behalf of Lewis) CansasReader has a property cansas_version which determines the xml header written in the files. This currently seems to default to 1.0 and not 1.1 as you get the old header if you call this class directly. However if you save xml files from the GUI they are saved with the new header! This suggests the default is over-ridden somewhere. Needs investigating.

[krzywon]

Cansas v1.0 file written after loading Cansas 1.0 data set

[krzywon]

Cansas v1.1 file written after loading Cansas 1.1 data set

[krzywon]

Cansas v1.0 file loaded

[krzywon]

Cansas v1.1 file loaded

[krzywon]

I have attached cansas 1.0 and 1.1 data files that can be loaded into sasview as well as saved data sets for each that show they are written with the proper header. Could you provide an example data file that is not saving properly?

[smk78]

No this was an issue calling the class from Python. It seems the default behaviour is to write 1.0?

[smk78]

If you don't load xml data - and thus give the program a hint as what version of xml it should write - where does it decide to write 1.1?

[krzywon]

OK, I get the issue now. That isn't right. Let me look into this.

[krzywon]

I've had no luck recreating this issue. All data I've saved through the GUI in cansas xml format gets saved as cansas v1.0, not v1.1. I tested in the 4.0 alpha release and running from the code base. I have saved projects, fits, p(r) inversions, and data plotted on graphs. All come out saved as v1.0.

[smk78]

Unless you have got your 1.0's and 1.1's transposed in that comment, you have indeed recreated the issue: why is the default to write 1.0 headers and not 1.1 headers?

[krzywon]

The default of writing as cansas 1.0 is because of the underlying code used to write the save states, fits, etc. Each perspective has its own cansas reader to call in the saved parameters from save states and analyses. These all expect cansas v1.0 right now. I have a local fix to start writing the data in v1.1, but none of these saved states are loadable yet. I will make the perspective readers look at the cansas version in the header, or see if I can get them all integrated into a single reader/writer.

[krzywon]

This will get fixed at the same time the save state is refactored. Moving to +1.