Changes between Initial Version and Version 1 of Ticket #1007, comment 2


Ignore:
Timestamp:
Oct 29, 2017 2:56:34 PM (7 years ago)
Author:
butler
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #1007, comment 2

    initial v1  
    1 I was looking to this and made a try to fix the problem in the branch ticket1007. SasView is freezing because the model has a combo box to select the shape of each interface and the possible values are stored in a tuple (self.model.fun_list), but the function _set_fun_box_list tries to access fun_list as a dictionary.  With the changes I did, now the model works. However, self.model.fun_list is still used like a dictionary in several places in basepage.py, so I expect similar problems in other cases. I guess that someone with a better understanding of the different uses of fun_list should finish the work before making the pull request. 
     1I was looking to this and made a try to fix the problem in the branch ticket1007. !SasView is freezing because the model has a combo box to select the shape of each interface and the possible values are stored in a tuple (self.model.fun_list), but the function _set_fun_box_list tries to access fun_list as a dictionary.  With the changes I did, now the model works. However, self.model.fun_list is still used like a dictionary in several places in basepage.py, so I expect similar problems in other cases. I guess that someone with a better understanding of the different uses of fun_list should finish the work before making the pull request.