Changes in / [bf227cd:a1c91c2] in sasmodels

File:

• sasmodels/convert.py (modified) (4 diffs)

sasmodels/convert.py

@@ -4 +4 @@
 import warnings
 
-STRUCTURE_FACTORS = [
-    'hardsphere',
-    'stickyhardsphere',
-    'squarewell',
-    'HayterMSAsq'
-]
 # List of models which SasView versions don't contain the explicit 'scale' argument.
 # When converting such a model, please update this list.
-MODELS_WITHOUT_SCALE = STRUCTURE_FACTORS + [
+MODELS_WITHOUT_SCALE = [
     'teubner_strey',
     'broad_peak',
@@ -27 +21 @@
 # List of models which SasView versions don't contain the explicit 'background' argument.
 # When converting such a model, please update this list.
-MODELS_WITHOUT_BACKGROUND = STRUCTURE_FACTORS + [
+MODELS_WITHOUT_BACKGROUND = [
     'guinier',
 ]
@@ -128 +122 @@
     # Note: update compare.constrain_pars to match
     name = model_info['id']
-    if name in MODELS_WITHOUT_SCALE:
+    if name in MODELS_WITHOUT_SCALE or model_info['structure_factor']:
         if oldpars.pop('scale', 1.0) != 1.0:
             warnings.warn("parameter scale not used in sasview %s"%name)
-    if name in MODELS_WITHOUT_BACKGROUND:
+    if name in MODELS_WITHOUT_BACKGROUND or model_info['structure_factor']:
         if oldpars.pop('background', 0.0) != 0.0:
             warnings.warn("parameter background not used in sasview %s"%name)
@@ -161 +155 @@
     name = model_info['id']
     # Note: update convert.revert_model to match
-    if name in MODELS_WITHOUT_SCALE:
+    if name in MODELS_WITHOUT_SCALE or model_info['structure_factor']:
         pars['scale'] = 1
-    if name in MODELS_WITHOUT_BACKGROUND:
+    if name in MODELS_WITHOUT_BACKGROUND or model_info['structure_factor']:
         pars['background'] = 0
     # sasview multiplies background by structure factor