Changeset a10364b in sasview

Timestamp:

Feb 18, 2015 8:52:50 AM (10 years ago)

Author:

krzywon

Branches:

master, ESS_GUI, ESS_GUI_Docs, ESS_GUI_batch_fitting, ESS_GUI_bumps_abstraction, ESS_GUI_iss1116, ESS_GUI_iss879, ESS_GUI_iss959, ESS_GUI_opencl, ESS_GUI_ordering, ESS_GUI_sync_sascalc, costrafo411, magnetic_scatt, release-4.1.1, release-4.1.2, release-4.2.2, release_4.0.1, ticket-1009, ticket-1094-headless, ticket-1242-2d-resolution, ticket-1243, ticket-1249, ticket885, unittest-saveload

Children:

5160609

Parents:

53df2ea

Message:

Found the issue with the failing tests in ScipyFitting? and fixed the
issue. The fitter was trying to check the value of a list item but the
check should have been against another list.

Files:

• src/sas/fit/ScipyFitting.py (modified) (1 diff)
• test/park_integration/test/utest_fit_cylinder.py (modified) (1 diff)
• test/sasdataloader/test/utest_averaging.py (modified) (1 diff)

src/sas/fit/ScipyFitting.py

@@ -115 +115 @@
             low,high = model.details[p][1:3]
             if low is not None and numpy.isfinite(low):
-                if p.value == 0:
+                if value == 0:
                     # This value works on Scipy
                     # Do not change numbers below

test/park_integration/test/utest_fit_cylinder.py

@@ -10 +10 @@
 from sas.dataloader.loader import Loader
 
-#@unittest.skip("")
 class TestSingleFit(unittest.TestCase):
     """ test single fitting """

test/sasdataloader/test/utest_averaging.py

@@ -196 +196 @@
         import math
         
+        nbins = 19
+        phi_min = math.pi / (nbins + 1)
+        phi_max = math.pi * 2 - phi_min
+        
         r = SectorPhi(r_min=.005,
                       r_max=.01,
-                      phi_min=0.15707963,
-                      phi_max=math.pi*2.-0.15707963,
-                      nbins=19)
+                      phi_min=phi_min,
+                      phi_max=phi_max,
+                      nbins=nbins)
         o = r(self.data)