Changeset 9e426c1 in sasview for src/sas/qtgui/UnitTesting

Timestamp:

Jun 21, 2016 8:07:33 AM (8 years ago)

Author:

Piotr Rozyczko <piotr.rozyczko@…>

Branches:

ESS_GUI, ESS_GUI_Docs, ESS_GUI_batch_fitting, ESS_GUI_bumps_abstraction, ESS_GUI_iss1116, ESS_GUI_iss879, ESS_GUI_iss959, ESS_GUI_opencl, ESS_GUI_ordering, ESS_GUI_sync_sascalc

Children:

f82ab8c

Parents:

1042dba

Message:

More main window items, system close, update checker, doc viewer etc.

Location:

src/sas/qtgui/UnitTesting

Files:

• DataExplorerTest.py (modified) (5 diffs)
• GuiManagerTest.py (modified) (4 diffs)
• MainWindowTest.py (modified) (2 diffs)

src/sas/qtgui/UnitTesting/DataExplorerTest.py

@@ -72 +72 @@
         loadButton = self.form.cmdLoad
 
-        # Mock the system file open method
-        QtGui.QFileDialog.getOpenFileName = MagicMock(return_value=None)
+        filename = "cyl_400_20.txt"
+        # Initialize signal spy instances
+        spy_file_read = QtSignalSpy(self.form, self.form.communicate.fileReadSignal)
+
+        # Return no files.
+        QtGui.QFileDialog.getOpenFileNames = MagicMock(return_value=None)
 
         # Click on the Load button
@@ -79 +83 @@
 
         # Test the getOpenFileName() dialog called once
-        self.assertTrue(QtGui.QFileDialog.getOpenFileName.called)
-        QtGui.QFileDialog.getOpenFileName.assert_called_once()
+        self.assertTrue(QtGui.QFileDialog.getOpenFileNames.called)
+        QtGui.QFileDialog.getOpenFileNames.assert_called_once()
+
+        # Make sure the signal has not been emitted
+        self.assertEqual(spy_file_read.count(), 0)
+
+        # Now, return a single file
+        QtGui.QFileDialog.getOpenFileNames = MagicMock(return_value=filename)
+        
+        # Click on the Load button
+        QTest.mouseClick(loadButton, Qt.LeftButton)
+
+        # Test the getOpenFileName() dialog called once
+        self.assertTrue(QtGui.QFileDialog.getOpenFileNames.called)
+        QtGui.QFileDialog.getOpenFileNames.assert_called_once()
+
+        # Expected one spy instance
+        self.assertEqual(spy_file_read.count(), 1)
+        self.assertIn(filename, str(spy_file_read.called()[0]['args'][0]))
 
     def testDeleteButton(self):
@@ -131 +152 @@
         QTest.mouseClick(deleteButton, Qt.LeftButton)
 
-
     def testSendToButton(self):
         """
@@ -166 +186 @@
         # Assure the message box popped up
         QtGui.QMessageBox.assert_called_once()
-
 
     def testDataSelection(self):
@@ -272 +291 @@
         Test the callback method updating the data object
         """
-
         message="Loading Data Complete"
         data_dict = {"a1":Data1D()}

src/sas/qtgui/UnitTesting/GuiManagerTest.py

@@ -1 +1 @@
 import sys
+import subprocess
 import unittest
+import webbrowser
+import logging
 
 from PyQt4.QtGui import *
 from PyQt4.QtTest import QTest
 from PyQt4.QtCore import *
+from PyQt4.QtWebKit import *
 from mock import MagicMock
 
@@ -10 +14 @@
 from GuiManager import GuiManager
 from UI.MainWindowUI import MainWindow
+from UnitTesting.TestUtils import QtSignalSpy
 
 app = QApplication(sys.argv)
@@ -56 +61 @@
         pass
 
+    def testQuitApplication(self):
+        """
+        Test that the custom exit method is called on shutdown
+        """
+        # Must mask sys.exit, otherwise the whole testing process stops.
+        sys.exit = MagicMock()
+
+        # Say No to the close dialog
+        QMessageBox.question = MagicMock(return_value=QMessageBox.No)
+
+        # Open, then close the manager
+        self.manager.quitApplication()
+
+        # See that the MessageBox method got called
+        self.assertTrue(QMessageBox.question.called)
+        # sys.exit() not called this time
+        self.assertFalse(sys.exit.called)
+
+        # Say Yes to the close dialog
+        QMessageBox.question = MagicMock(return_value=QMessageBox.Yes)
+
+        # Open, then close the manager
+        self.manager.quitApplication()
+
+        # See that the MessageBox method got called
+        self.assertTrue(QMessageBox.question.called)
+        # Also, sys.exit() called
+        self.assertTrue(sys.exit.called)
+
+    def testCheckUpdate(self):
+        """
+        Tests the SasView website version polling
+        """
+        self.manager.processVersion = MagicMock()
+        version = {'update_url'  : 'http://www.sasview.org/sasview.latestversion', 
+                   'version'     : '3.1.2',
+                   'download_url': 'https://github.com/SasView/sasview/releases'}
+        self.manager.checkUpdate()
+
+        self.manager.processVersion.assert_called_with(version)
+
+        pass
+
+    def testProcessVersion(self):
+        """
+        Tests the version checker logic
+        """
+        # 1. version = 0.0.0
+        version_info = {u'version' : u'0.0.0'}
+        spy_status_update = QtSignalSpy(self.manager, self.manager.communicate.statusBarUpdateSignal)
+
+        self.manager.processVersion(version_info)
+
+        self.assertEqual(spy_status_update.count(), 1)
+        message = 'Could not connect to the application server. Please try again later.'
+        self.assertIn(message, str(spy_status_update.signal(index=0)))
+
+        # 2. version < LocalConfig.__version__
+        version_info = {u'version' : u'0.0.1'}
+        spy_status_update = QtSignalSpy(self.manager, self.manager.communicate.statusBarUpdateSignal)
+
+        self.manager.processVersion(version_info)
+
+        self.assertEqual(spy_status_update.count(), 1)
+        message = 'You have the latest version of SasView'
+        self.assertIn(message, str(spy_status_update.signal(index=0)))
+
+        # 3. version > LocalConfig.__version__
+        version_info = {u'version' : u'999.0.0'}
+        spy_status_update = QtSignalSpy(self.manager, self.manager.communicate.statusBarUpdateSignal)
+        webbrowser.open = MagicMock()
+
+        self.manager.processVersion(version_info)
+
+        self.assertEqual(spy_status_update.count(), 1)
+        message = 'Version 999.0.0 is available!'
+        self.assertIn(message, str(spy_status_update.signal(index=0)))
+
+        webbrowser.open.assert_called_with("https://github.com/SasView/sasview/releases")
+
+        # 4. version > LocalConfig.__version__ and standalone
+        version_info = {u'version' : u'999.0.0'}
+        spy_status_update = QtSignalSpy(self.manager, self.manager.communicate.statusBarUpdateSignal)
+        webbrowser.open = MagicMock()
+
+        self.manager.processVersion(version_info, standalone=True)
+
+        self.assertEqual(spy_status_update.count(), 1)
+        message = 'See the help menu to download it'
+        self.assertIn(message, str(spy_status_update.signal(index=0)))
+
+        self.assertFalse(webbrowser.open.called)
+
+        # 5. couldn't load version
+        version_info = {}
+        logging.error = MagicMock()
+        spy_status_update = QtSignalSpy(self.manager, self.manager.communicate.statusBarUpdateSignal)
+
+        self.manager.processVersion(version_info)
+
+        # Retrieve and compare arguments of the mocked call
+        message = "guiframe: could not get latest application version number"
+        args, _ = logging.error.call_args
+        self.assertIn(message, args[0])
+
+        # Check the signal message
+        message = 'Could not connect to the application server.'
+        self.assertIn(message, str(spy_status_update.signal(index=0)))
+
     def testActions(self):
         """
@@ -66 +180 @@
         """
         # Mock the system file open method
-        QFileDialog.getOpenFileName = MagicMock(return_value=None)
+        QFileDialog.getOpenFileNames = MagicMock(return_value=None)
 
         # invoke the action
+        self.manager.actionLoadData()
 
         # Test the getOpenFileName() dialog called once
-        #self.assertTrue(QtGui.QFileDialog.getOpenFileName.called)
-        #QtGui.QFileDialog.getOpenFileName.assert_called_once()
+        self.assertTrue(QFileDialog.getOpenFileNames.called)
         
-
-    # test each action separately
+    def testActionDocumentation(self):
+        """
+        Menu Help/Documentation
+        """
+        #Mock the QWebView method
+        QWebView.show = MagicMock()
+
+        # Assure the filename is correct
+        self.assertIn("index.html", self.manager._helpLocation)
+
+        # Invoke the action
+        self.manager.actionDocumentation()
+
+        # Check if show() got called
+        self.assertTrue(QWebView.show.called)
+
+    def testActionTutorial(self):
+        """
+        Menu Help/Tutorial
+        """
+        # Mock subprocess.Popen
+        subprocess.Popen = MagicMock()
+
+        tested_location = self.manager._tutorialLocation
+
+        # Assure the filename is correct
+        self.assertIn("Tutorial.pdf", tested_location)
+
+        # Invoke the action
+        self.manager.actionTutorial()
+
+        # Check if popen() got called
+        self.assertTrue(subprocess.Popen.called)
+
+        #Check the popen() call arguments
+        subprocess.Popen.assert_called_with([tested_location], shell=True)
+
+    def testActionAcknowledge(self):
+        """
+        Menu Help/Acknowledge
+        """
+        pass
+
+    def testActionCheck_for_update(self):
+        """
+        Menu Help/Check for update
+        """
+        # Just make sure checkUpdate is called.
+        self.manager.checkUpdate = MagicMock()
+
+        self.manager.actionCheck_for_update()
+
+        self.assertTrue(self.manager.checkUpdate.called)
+             
        
 if __name__ == "__main__":

src/sas/qtgui/UnitTesting/MainWindowTest.py

@@ -2 +2 @@
 import unittest
 
-from PyQt4.QtGui import *
-from PyQt4.QtTest import QTest
-from PyQt4.QtCore import *
+from PyQt4 import QtGui
+from PyQt4 import QtTest
+from PyQt4 import QtCore
 from mock import MagicMock
 
@@ -11 +11 @@
 from MainWindow import SplashScreen
 
-app = QApplication(sys.argv)
+app = QtGui.QApplication(sys.argv)
 
 class MainWindowTest(unittest.TestCase):
-    '''Test the Main Window GUI'''
+    """Test the Main Window GUI"""
     def setUp(self):
-        '''Create the GUI'''
+        """Create the GUI"""
 
         self.widget = MainSasViewWindow(None)
 
     def tearDown(self):
-        '''Destroy the GUI'''
-        self.widget.close()
+        """Destroy the GUI"""
         self.widget = None
 
     def testDefaults(self):
-        '''Test the GUI in its default state'''
-        self.assertIsInstance(self.widget, QMainWindow)
-        self.assertIsInstance(self.widget.centralWidget(), QWorkspace)
+        """Test the GUI in its default state"""
+        self.assertIsInstance(self.widget, QtGui.QMainWindow)
+        self.assertIsInstance(self.widget.centralWidget(), QtGui.QWorkspace)
         
     def testSplashScreen(self):
+        """ Test the splash screen """
+        splash = SplashScreen()
+        self.assertIsInstance(splash, QtGui.QSplashScreen)
+
+    def testExit(self):
         """
+        Test that the custom exit method is called on shutdown
         """
-        splash = SplashScreen()
-        self.assertIsInstance(splash, QSplashScreen)
+        # Must mask sys.exit, otherwise the whole testing process stops.
+        sys.exit = MagicMock()
+        QtGui.QMessageBox.question = MagicMock(return_value=QtGui.QMessageBox.Yes)
+
+        # Open, then close the main window
+        tmp_main = MainSasViewWindow(None)
+        tmp_main.close()
+
+        # See that the MessageBox method got called
+        self.assertTrue(QtGui.QMessageBox.question.called)
        
 if __name__ == "__main__":