Changeset 94f074c4 in sasview for test

Timestamp:

Apr 10, 2018 6:01:14 AM (6 years ago)

Author:

GitHub <noreply@…>

Branches:

master, magnetic_scatt, release-4.2.2, ticket-1009, ticket-1094-headless, ticket-1242-2d-resolution, ticket-1243, ticket-1249, unittest-saveload

Children:

3388337, 1176137

Parents:

fc25457 (diff), 63ddc03 (diff)
Note: this is a merge changeset, the changes displayed below correspond to the merge itself.
Use the (diff) links above to see all the changes relative to each parent.

git-author:

Jeff Krzywon <krzywon@…> (04/10/18 06:01:14)

git-committer:

GitHub <noreply@…> (04/10/18 06:01:14)

Message:

Merge pull request #143 from SasView?/ticket-1068-2

Fixes #1068

Location:

test/sasdataloader/test

Files:

• FEB18012.ASC (added)
• test_data/TestExtensions (added)
• test_data/TestExtensions.asc (added)
• test_data/TestExtensions.notxml (added)
• test_data/TestExtensions.nxs (added)
• test_data/TestExtensions.xml (added)
• utest_generic_file_reader_class.py (modified) (3 diffs)

test/sasdataloader/test/utest_generic_file_reader_class.py

@@ -8 +8 @@
 import numpy as np
 
-from sas.sascalc.dataloader.data_info import DataInfo, plottable_1D
+from sas.sascalc.dataloader.data_info import DataInfo, plottable_1D, Data1D
+from sas.sascalc.dataloader.loader import Loader
+from sas.sascalc.dataloader.loader_exceptions import NoKnownLoaderException
 from sas.sascalc.dataloader.file_reader_base_class import FileReader
 
@@ -24 +26 @@
         self.bad_file = find("ACB123.txt")
         self.good_file = find("123ABC.txt")
+        self.generic_reader = Loader()
+        self.deprecated_file_type = find("FEB18012.ASC")
 
     def test_bad_file_path(self):
-        output = self.reader.read(self.bad_file)
-        self.assertEqual(output, [])
+        self.assertRaises(NoKnownLoaderException, self.reader.read,
+                          self.bad_file)
 
     def test_good_file_path(self):
@@ -36 +40 @@
         self.assertEqual(len(output), 1)
         self.assertEqual(output[0].meta_data["blah"], '123ABC exists!')
+
+    def test_old_file_types(self):
+        f = self.generic_reader.load(self.deprecated_file_type)
+        last_f = f[0]
+        if hasattr(last_f, "errors"):
+            self.assertEquals(len(last_f.errors), 1)
+        else:
+            self.fail("Errors did not propogate to the file properly.")
+
+    def test_same_file_unknown_extensions(self):
+        # Five files, all with the same content, but different file extensions
+        no_ext = find("test_data//TestExtensions")
+        not_xml = find("test_data//TestExtensions.notxml")
+        # Deprecated extensions
+        asc_dep = find("test_data//TestExtensions.asc")
+        nxs_dep = find("test_data//TestExtensions.nxs")
+        # Native extension as a baseline
+        xml_native = find("test_data//TestExtensions.xml")
+        # Load the files and check contents
+        no_ext_load = self.generic_reader.load(no_ext)
+        asc_load = self.generic_reader.load(asc_dep)
+        nxs_load = self.generic_reader.load(nxs_dep)
+        not_xml_load = self.generic_reader.load(not_xml)
+        xml_load = self.generic_reader.load(xml_native)
+        self.check_unknown_extension(no_ext_load[0])
+        self.check_unknown_extension(asc_load[0])
+        self.check_unknown_extension(nxs_load[0])
+        self.check_unknown_extension(not_xml_load[0])
+        self.check_unknown_extension(xml_load[0])
+        # Be sure the deprecation warning is passed with the file
+        self.assertEquals(len(asc_load[0].errors), 1)
+        self.assertEquals(len(nxs_load[0].errors), 1)
+
+    def check_unknown_extension(self, data):
+        self.assertTrue(isinstance(data, Data1D))
+        self.assertEquals(len(data.x), 138)
+        self.assertEquals(data.sample.ID, "TK49 c10_SANS")
+        self.assertEquals(data.meta_data["loader"], "CanSAS XML 1D")
 
     def tearDown(self):