Changeset 8873ab7 in sasview for src

Timestamp:

Sep 19, 2018 9:35:51 AM (6 years ago)

Author:

Piotr Rozyczko <piotrrozyczko@…>

Branches:

ESS_GUI, ESS_GUI_batch_fitting, ESS_GUI_bumps_abstraction, ESS_GUI_iss1116, ESS_GUI_opencl, ESS_GUI_ordering, ESS_GUI_sync_sascalc

Children:

9d23e4c

Parents:

d1e4689

git-author:

Piotr Rozyczko <piotrrozyczko@…> (09/19/18 09:32:51)

git-committer:

Piotr Rozyczko <piotrrozyczko@…> (09/19/18 09:35:51)

Message:

Fixed issue with bumps monitors showing up as algorithm options. SASVIEW-1090.
Also, added check for unsupported algorithms.

File:

• src/sas/qtgui/Perspectives/Fitting/FittingOptions.py (modified) (5 diffs)

src/sas/qtgui/Perspectives/Fitting/FittingOptions.py

@@ -64 +64 @@
         default_index = self.cbAlgorithm.findText(default_name)
         self.cbAlgorithm.setCurrentIndex(default_index)
+        # previous algorithm choice
+        self.previous_index = default_index
 
         # Assign appropriate validators
@@ -121 +123 @@
 
         # Convert the name into widget instance
-        widget_to_activate = eval(widget_name)
+        try:
+            widget_to_activate = eval(widget_name)
+        except AttributeError:
+            # We don't yet have this optimizer.
+            # Show message
+            msg = "This algorithm has not yet been implemented in SasView.\n"
+            msg += "Please choose a different algorithm"
+            QtWidgets.QMessageBox.warning(self,
+                                        'Warning',
+                                        msg,
+                                        QtWidgets.QMessageBox.Ok)
+            # Move the index to previous position
+            self.cbAlgorithm.setCurrentIndex(self.previous_index)
+            return
+
         index_for_this_id = self.stackedWidget.indexOf(widget_to_activate)
 
@@ -133 +149 @@
         # OK has to be reinitialized to True
         self.buttonBox.button(QtWidgets.QDialogButtonBox.Ok).setEnabled(True)
+
+        # keep reference
+        self.previous_index = index
 
     def onApply(self):
@@ -143 +162 @@
             # e.g. 'samples' for 'dream' is 'self.samples_dream'
             widget_name = 'self.'+option+'_'+self.current_fitter_id
-            line_edit = eval(widget_name)
+            try:
+                line_edit = eval(widget_name)
+            except AttributeError:
+                # Skip bumps monitors
+                continue
             if line_edit is None or not isinstance(line_edit, QtWidgets.QLineEdit):
                 continue
@@ -165 +188 @@
                 return
             try:
-                new_value = widget.currentText() if isinstance(widget, QtWidgets.QComboBox) \
-                    else float(widget.text())
+                if isinstance(widget, QtWidgets.QComboBox):
+                    new_value = widget.currentText()
+                else:
+                    try:
+                        new_value = int(widget.text())
+                    except ValueError:
+                        new_value = float(widget.text())
+                #new_value = widget.currentText() if isinstance(widget, QtWidgets.QComboBox) \
+                #    else float(widget.text())
                 self.config.values[self.current_fitter_id][option] = new_value
             except ValueError: