Changeset 8662a58 in sasview

Timestamp:

Oct 10, 2016 4:01:05 PM (8 years ago)

Author:

ajj

Branches:

master, ESS_GUI, ESS_GUI_Docs, ESS_GUI_batch_fitting, ESS_GUI_bumps_abstraction, ESS_GUI_iss1116, ESS_GUI_iss879, ESS_GUI_iss959, ESS_GUI_opencl, ESS_GUI_ordering, ESS_GUI_sync_sascalc, costrafo411, magnetic_scatt, release-4.1.1, release-4.1.2, release-4.2.2, ticket-1009, ticket-1094-headless, ticket-1242-2d-resolution, ticket-1243, ticket-1249, ticket885, unittest-saveload

Children:

3bec50a, f22b43c, 199b515e

Parents:

68669da

Message:

Updating basepage and fitpage to pass is_modified flag out of helper functions so that _onDraw can correctly determine that there is a change and recalculate/redraw

Fixes #753 compute button no longer seems to work

Location:

src/sas/sasgui/perspectives/fitting

Files:

• basepage.py (modified) (7 diffs)
• fitpage.py (modified) (1 diff)

src/sas/sasgui/perspectives/fitting/basepage.py

@@ -1382 +1382 @@
         self.state.npts = self.npts_x
 
-    def _onparamEnter_helper(self):
+    def _onparamEnter_helper(self, is_modified=False):
         """
         check if values entered by the user are changed and valid to replot
@@ -1388 +1388 @@
         """
         # Flag to register when a parameter has changed.
-        is_modified = False
+        #is_modified = False
         self.fitrange = True
         is_2Ddata = False
@@ -1396 +1396 @@
             is_2Ddata = True
         if self.model != None:
-            is_modified = (self._check_value_enter(self.fittable_param)
-                           or self._check_value_enter(self.fixed_param)
-                           or self._check_value_enter(self.parameters))
+            #Either we get a is_modified = True passed in because
+            #_update_paramv_on_fit() has been called already or
+            # we need to check here ourselves.
+            if not is_modified:
+                is_modified = (self._check_value_enter(self.fittable_param)
+                               or self._check_value_enter(self.fixed_param)
+                               or self._check_value_enter(self.parameters))
 
             # Here we should check whether the boundaries have been modified.
@@ -1436 +1440 @@
                 self.Refresh()
 
-        logging.info("is_modified flag set to %g",is_modified)
+        #logging.info("is_modified flag set to %g",is_modified)
         return is_modified
 
@@ -1446 +1450 @@
         flag = True
         self.fitrange = True
+        is_modified = False
 
         #wx.PostEvent(self._manager.parent, StatusEvent(status=" \
@@ -1458 +1463 @@
                                                                 [self.data])
             ##Check the values
-            self._check_value_enter(self.fittable_param)
-            self._check_value_enter(self.fixed_param)
-            self._check_value_enter(self.parameters)
+            is_modified = (self._check_value_enter(self.fittable_param)
+                            or self._check_value_enter(self.fixed_param)
+                            or self._check_value_enter(self.parameters))
 
             # If qmin and qmax have been modified, update qmin and qmax and
@@ -1542 +1547 @@
             logging.error(traceback.format_exc())
 
-        return flag
+        return flag,is_modified
 
     def _reset_parameters_state(self, listtorestore, statelist):

src/sas/sasgui/perspectives/fitting/fitpage.py

@@ -996 +996 @@
             self.create_default_data()
         """
-        flag = self._update_paramv_on_fit()
-
-        wx.CallAfter(self._onparamEnter_helper)
+        flag,is_modified = self._update_paramv_on_fit()
+
+        wx.CallAfter(self._onparamEnter_helper(is_modified))
         if not flag:
             msg = "The parameters are invalid"