Changeset 7c487846 in sasview for src/sas/qtgui

Timestamp:

Nov 14, 2017 6:04:41 AM (7 years ago)

Author:

Piotr Rozyczko <rozyczko@…>

Branches:

ESS_GUI, ESS_GUI_Docs, ESS_GUI_batch_fitting, ESS_GUI_bumps_abstraction, ESS_GUI_iss1116, ESS_GUI_iss879, ESS_GUI_iss959, ESS_GUI_opencl, ESS_GUI_ordering, ESS_GUI_sync_sascalc

Children:

fa81e94

Parents:

f1f3e6a

Message:

Fixes to the Invariant perspective

Location:

src/sas/qtgui

Files:

• GUITests.py (modified) (4 diffs)
• MainWindow/GuiManager.py (modified) (1 diff)
• Perspectives/Fitting/FittingPerspective.py (modified) (1 diff)
• Perspectives/Fitting/FittingWidget.py (modified) (1 diff)
• Perspectives/Invariant/InvariantDetails.py (modified) (2 diffs)
• Perspectives/Invariant/InvariantPerspective.py (modified) (8 diffs)
• Perspectives/Invariant/UnitTesting/InvariantDetailsTest.py (modified) (2 diffs)
• Perspectives/Invariant/UnitTesting/InvariantPerspectiveTest.py (modified) (4 diffs)

src/sas/qtgui/GUITests.py

@@ -49 +49 @@
 
 # Perspectives
-#import path_prepare
+#  Fitting
 from Perspectives.Fitting.UnitTesting import FittingWidgetTest
 from Perspectives.Fitting.UnitTesting import FittingPerspectiveTest
@@ -56 +56 @@
 from Perspectives.Fitting.UnitTesting import FitPageTest
 from Perspectives.Fitting.UnitTesting import FittingOptionsTest
+#  Invariant
+from Perspectives.Invariant.UnitTesting import InvariantPerspectiveTest
+from Perspectives.Invariant.UnitTesting import InvariantDetailsTest
+
 
 def suite():
@@ -100 +104 @@
 
         # Perspectives
+        #  Fitting
         unittest.makeSuite(FittingPerspectiveTest.FittingPerspectiveTest, 'test'),
         unittest.makeSuite(FittingWidgetTest.FittingWidgetTest,           'test'),
@@ -106 +111 @@
         unittest.makeSuite(FitPageTest.FitPageTest,                       'test'),
         unittest.makeSuite(FittingOptionsTest.FittingOptionsTest,         'test'),
+        #  Invariant
+        unittest.makeSuite(InvariantPerspectiveTest.InvariantPerspectiveTest,  'test'),
+        unittest.makeSuite(InvariantDetailsTest.InvariantDetailsTest,     'test'),
      )
     return unittest.TestSuite(suites)

src/sas/qtgui/MainWindow/GuiManager.py

@@ -194 +194 @@
         if self._current_perspective:
             self._current_perspective.setClosable()
+            #self._workspace.workspace.removeSubWindow(self._current_perspective)
             self._current_perspective.close()
+            self._workspace.workspace.removeSubWindow(self._current_perspective)
         # Default perspective
         self._current_perspective = Perspectives.PERSPECTIVES[str(perspective_name)](parent=self)

src/sas/qtgui/Perspectives/Fitting/FittingPerspective.py

@@ -91 +91 @@
         """
         # Invoke fit page events
-        for tab in self.tabs:
-            tab.close()
         if self._allow_close:
             # reset the closability flag
             self.setClosable(value=False)
+            # Tell the MdiArea to close the container
+            self.parentWidget().close()
             event.accept()
         else:

src/sas/qtgui/Perspectives/Fitting/FittingWidget.py

@@ -137 +137 @@
         if data is not None:
             self.data = data
-
-    #def close(self):
-    #    """
-    #    Remember to kill off things on exit
-    #    """
-    #    self.helpView.close()
-    #    del self.helpView
 
     @property

src/sas/qtgui/Perspectives/Invariant/InvariantDetails.py

@@ -81 +81 @@
         self.txtQDataErr.setText(self._model.item(WIDGETS.W_INVARIANT_ERR).text())
 
+        # Reset progress counters
+        self.progress_low_qstar = 0.0
+        self.progress_high_qstar = 0.0
+        self.progress_qstar = 100.0
+
         # Low-Q
         if self._model.item(WIDGETS.W_ENABLE_LOWQ).text() == "true":
@@ -147 +152 @@
         if self.progress_qstar == 'error':
             msg += 'Error occurred when computing invariant from data.\n '
-        if self.progress_qstar > 100:
-            msg += "Invariant Q contribution is greater than 100% .\n"
+        try:
+            if float(self.progress_qstar) > 100:
+                msg += "Invariant Q contribution is greater than 100% .\n"
+        except ValueError:
+            # Text message, skip msg update
+            pass
 
         if self.progress_low_qstar == 'error':

src/sas/qtgui/Perspectives/Invariant/InvariantPerspective.py

@@ -125 +125 @@
         self.setupMapper()
 
+        # Default enablement
+        self.cmdCalculate.setEnabled(False)
+
         # validator: double
-        self.txtBackgd.setValidator(QtGui.QDoubleValidator())
-        self.txtContrast.setValidator(QtGui.QDoubleValidator())
-        self.txtScale.setValidator(QtGui.QDoubleValidator())
-        self.txtPorodCst.setValidator(QtGui.QDoubleValidator())
+        self.txtBackgd.setValidator(GuiUtils.DoubleValidator())
+        self.txtContrast.setValidator(GuiUtils.DoubleValidator())
+        self.txtScale.setValidator(GuiUtils.DoubleValidator())
+        self.txtPorodCst.setValidator(GuiUtils.DoubleValidator())
 
         # validator: integer number
-        valid_regex_int = QtCore.QRegExp('^[+]?(\d+[.][0]*)$')
-        self.txtNptsLowQ.setValidator(QtGui.QRegExpValidator(valid_regex_int,
-                                                             self.txtNptsLowQ))
-        self.txtNptsHighQ.setValidator(QtGui.QRegExpValidator(valid_regex_int,
-                                                             self.txtNptsHighQ))
-        self.txtPowerLowQ.setValidator(QtGui.QRegExpValidator(valid_regex_int,
-                                                             self.txtPowerLowQ))
-        self.txtPowerHighQ.setValidator(QtGui.QRegExpValidator(valid_regex_int,
-                                                             self.txtPowerHighQ))
+        self.txtNptsLowQ.setValidator(QtGui.QIntValidator())
+        self.txtNptsHighQ.setValidator(QtGui.QIntValidator())
+        self.txtPowerLowQ.setValidator(GuiUtils.DoubleValidator())
+        self.txtPowerHighQ.setValidator(GuiUtils.DoubleValidator())
 
     def enabling(self):
@@ -159 +157 @@
             # reset the closability flag
             self.setClosable(value=False)
+            # Tell the MdiArea to close the container
+            self.parentWidget().close()
             event.accept()
         else:
@@ -227 +227 @@
 
         self.model = model
-        self.mapper.toFirst()
         self._data = GuiUtils.dataFromItem(self._model_item)
 
@@ -331 +330 @@
 
         if (calculation_failed):
-            self.mapper.toFirst()
             logging.warning('Calculation failed: {}'.format(msg))
             return self.model
@@ -416 +414 @@
             self.model.setItem(WIDGETS.D_HIGH_QSTAR_ERR, item)
 
-            self.mapper.toFirst()
-
             return self.model
 
@@ -504 +500 @@
         Error if it is larger than the distribution length
         """
+        try:
+            int_value = int(self.sender().text())
+        except ValueError:
+            self.sender().setStyleSheet(BG_RED)
+            self.cmdCalculate.setEnabled(False)
+            return
+
         if self._data:
-            if len(self._data.x) < int(self.sender().text()):
-                self.sender().setStyleSheet(QtCore.QString(BG_RED))
+            if len(self._data.x) < int_value:
+                self.sender().setStyleSheet(BG_RED)
                 logging.warning('The number of points must be smaller than {}'.format(len(self._data.x)))
                 self.cmdCalculate.setEnabled(False)
             else:
-                self.sender().setStyleSheet(QtCore.QString(BG_WHITE))
+                self.sender().setStyleSheet(BG_WHITE)
                 self.cmdCalculate.setEnabled(True)
         else:
@@ -565 +568 @@
 
         self.model.setItem(related_widgets[index_elt], item)
-
-        related_internal_values[index_elt] = float(self.sender().text())
-
-        # print possible_senders[index_elt], related_internal_values[index_elt]
-
-        self.mapper.toFirst()
+        try:
+            related_internal_values[index_elt] = float(self.sender().text())
+            self.sender().setStyleSheet(BG_WHITE)
+            self.cmdCalculate.setEnabled(True)
+        except ValueError:
+            # empty field, just skip
+            self.sender().setStyleSheet(BG_RED)
+            self.cmdCalculate.setEnabled(False)
 
     def lowGuinierAndPowerToggle(self, toggle):
@@ -761 +766 @@
         # Extract data on 1st child - this is the Data1D/2D component
         data = GuiUtils.dataFromItem(self._model_item)
-        self.model.item(WIDGETS.W_FILENAME).setData(QtCore.QVariant(self._model_item.text()))
+        self.model.item(WIDGETS.W_FILENAME).setData(self._model_item.text())
         # update GUI and model with info from loaded data
         self.updateGuiFromFile(data=data)

src/sas/qtgui/Perspectives/Invariant/UnitTesting/InvariantDetailsTest.py

@@ -8 +8 @@
 from PyQt5.QtTest import QTest
 from PyQt5.QtCore import Qt
-from mock import MagicMock
-from mock import patch
+from unittest.mock import MagicMock
+from unittest.mock import patch
 
 from twisted.internet import threads
@@ -138 +138 @@
         self.widget.qstar_total = 10
         self.widget.progress_qstar = 'error'
-        self.assertEqual(self.widget.checkValues(), "Error occurred when computing invariant from data.\n Invariant Q contribution is greater than 100% .\n")
+        self.assertIn("Error occurred when computing invariant from data.", self.widget.checkValues())
 
         self.widget.progress_qstar = 0

src/sas/qtgui/Perspectives/Invariant/UnitTesting/InvariantPerspectiveTest.py

@@ -8 +8 @@
 from PyQt5.QtTest import QTest
 from PyQt5.QtCore import Qt
-from mock import MagicMock
-from mock import patch
-from mock import create_autospec
+from unittest.mock import MagicMock
+from unittest.mock import patch
+from unittest.mock import create_autospec
 
 from twisted.internet import threads
@@ -23 +23 @@
 import sas.qtgui.Utilities.GuiUtils as GuiUtils
 
-if not QtWidgets.QApplication.instance():
-    app = QtWidgets.QApplication(sys.argv)
+#if not QtWidgets.QApplication.instance():
+app = QtWidgets.QApplication(sys.argv)
 
 BG_COLOR_ERR = 'background-color: rgb(244, 170, 164);'
@@ -142 +142 @@
 
         # Validators
-        self.assertIsInstance(self.widget.txtNptsLowQ.validator(), QtGui.QRegExpValidator)
-        self.assertIsInstance(self.widget.txtNptsHighQ.validator(), QtGui.QRegExpValidator)
-        self.assertIsInstance(self.widget.txtPowerLowQ.validator(), QtGui.QRegExpValidator)
-        self.assertIsInstance(self.widget.txtPowerHighQ.validator(), QtGui.QRegExpValidator)
-
-        self.assertIsInstance(self.widget.txtBackgd.validator(), QtGui.QDoubleValidator)
-        self.assertIsInstance(self.widget.txtContrast.validator(), QtGui.QDoubleValidator)
-        self.assertIsInstance(self.widget.txtScale.validator(), QtGui.QDoubleValidator)
-        self.assertIsInstance(self.widget.txtPorodCst.validator(), QtGui.QDoubleValidator)
+        self.assertIsInstance(self.widget.txtNptsLowQ.validator(), QtGui.QIntValidator)
+        self.assertIsInstance(self.widget.txtNptsHighQ.validator(), QtGui.QIntValidator)
+        self.assertIsInstance(self.widget.txtPowerLowQ.validator(), GuiUtils.DoubleValidator)
+        self.assertIsInstance(self.widget.txtPowerHighQ.validator(), GuiUtils.DoubleValidator)
+
+        self.assertIsInstance(self.widget.txtBackgd.validator(), GuiUtils.DoubleValidator)
+        self.assertIsInstance(self.widget.txtContrast.validator(), GuiUtils.DoubleValidator)
+        self.assertIsInstance(self.widget.txtScale.validator(), GuiUtils.DoubleValidator)
+        self.assertIsInstance(self.widget.txtPorodCst.validator(), GuiUtils.DoubleValidator)
 
         # Test autoexclusivity of radiobuttons
@@ -202 +202 @@
         # self.assertEqual(self.widget._data.y[1], 4)
 
-    def testHelp(self):
+    def notestHelp(self):
         """ Assure help file is shown """
         # this should not rise