Changeset 6c7ebb88 in sasview for src/sas/qtgui

Timestamp:

Mar 31, 2019 8:04:26 AM (6 years ago)

Author:

GitHub <noreply@…>

Parents:

f994f188 (diff), d32a594 (diff)
Note: this is a merge changeset, the changes displayed below correspond to the merge itself.
Use the (diff) links above to see all the changes relative to each parent.

git-author:

Adam Washington <rprospero@…> (03/31/19 08:04:26)

git-committer:

GitHub <noreply@…> (03/31/19 08:04:26)

Message:

Merge d32a594acc82ad29555832f498167b51564c75f3 into f994f188e28dca36e7823b2deb3bf2bfc351c35c

Location:

src/sas/qtgui

Files:

• Plotting/Plotter.py (modified) (1 diff)
• Plotting/UnitTesting/PlotterTest.py (modified) (2 diffs)
• Calculators/UnitTesting/GenericScatteringCalculatorTest.py (modified) (5 diffs)
• Calculators/UnitTesting/SLDCalculatorTest.py (modified) (5 diffs)
• MainWindow/UnitTesting/DataExplorerTest.py (modified) (2 diffs)
• MainWindow/UnitTesting/GuiManagerTest.py (modified) (1 diff)
• Perspectives/Fitting/ComplexConstraint.py (modified) (1 diff)
• Perspectives/Fitting/ConstraintWidget.py (modified) (5 diffs)
• Perspectives/Fitting/FittingUtilities.py (modified) (4 diffs)
• Perspectives/Fitting/FittingWidget.py (modified) (5 diffs)
• Perspectives/Fitting/OptionsWidget.py (modified) (1 diff)
• Perspectives/Fitting/SmearingWidget.py (modified) (9 diffs)
• Perspectives/Fitting/UnitTesting/FittingWidgetTest.py (modified) (4 diffs)
• Plotting/PlotterBase.py (modified) (2 diffs)
• Utilities/UnitTesting/TabbedModelEditorTest.py (modified) (1 diff)

src/sas/qtgui/Plotting/Plotter.py

@@ -91 +91 @@
             # make sure we have some function to operate on
             if self.data.xtransform is None:
-                self.data.xtransform = 'log10(x)'
+                if self.data.isSesans:
+                    self.data.xtransform='x'
+                else:
+                    self.data.xtransform = 'log10(x)'
             if self.data.ytransform is None:
-                self.data.ytransform = 'log10(y)'
+                if self.data.isSesans:
+                    self.data.ytransform='y'
+                else:
+                    self.data.ytransform = 'log10(y)'
             #Added condition to Dmax explorer from P(r) perspective
             if self.data._xaxis == 'D_{max}':

src/sas/qtgui/Plotting/UnitTesting/PlotterTest.py

@@ -81 +81 @@
         """ Ensure that Sesans data is plotted in linear cooredinates"""
         data = Data1D(x=[1.0, 2.0, 3.0],
-                      y=[10.0, 11.0, 12.0],
+                      y=[-10.0, -11.0, -12.0],
                       dx=[0.1, 0.2, 0.3],
                       dy=[0.1, 0.2, 0.3])
@@ -97 +97 @@
         self.assertEqual(self.plotter.ax.get_xscale(), 'linear')
         self.assertEqual(self.plotter.ax.get_yscale(), 'linear')
+        self.assertEqual(self.plotter.data.ytransform, "y")
         self.assertTrue(FigureCanvas.draw_idle.called)
 

src/sas/qtgui/Calculators/UnitTesting/GenericScatteringCalculatorTest.py

@@ -186 +186 @@
         # wait a bit for data to be loaded
         time.sleep(0.1)
+        QtWidgets.qApp.processEvents()
+
         # check updated values in ui, read from loaded file
         self.assertEqual(self.widget.txtData.text(), 'sld_file.sld')
@@ -250 +252 @@
 
         time.sleep(1)
+        QtWidgets.qApp.processEvents()
+
         # check updated values in ui, read from loaded file
         # TODO to be changed
@@ -310 +314 @@
         self.assertEqual(self.widget.cmdLoad.text(), 'Loading...')
         time.sleep(2)
+        QtWidgets.qApp.processEvents()
 
         self.assertEqual(self.widget.txtData.text(), 'A_Raw_Example-1.omf')
@@ -396 +401 @@
         self.assertEqual(self.widget.cmdLoad.text(), 'Loading...')
         time.sleep(1)
+        QtWidgets.qApp.processEvents()
 
         self.assertTrue(self.widget.cmdDraw.isEnabled())
@@ -417 +423 @@
 
         time.sleep(0.1)
+        QtWidgets.qApp.processEvents()
 
         filename1 = "test"
         QtWidgets.QFileDialog.getSaveFileName = MagicMock(return_value=[filename1, ''])
 
-        QTest.mouseClick(self.widget.cmdSave, Qt.LeftButton)
+        #QTest.mouseClick(self.widget.cmdSave, Qt.LeftButton)
         self.widget.onSaveFile()
+        QtWidgets.qApp.processEvents()
+
         self.assertTrue(os.path.isfile(filename1 + '.sld'))
         self.assertTrue(os.path.getsize(filename1 + '.sld') > 0)

src/sas/qtgui/Calculators/UnitTesting/SLDCalculatorTest.py

@@ -13 +13 @@
 
 # Local
-from sas.qtgui.Calculators.SldPanel import SldResult
+#from sas.qtgui.Calculators.SldPanel import SldResult
 from sas.qtgui.Calculators.SldPanel import SldPanel
-from sas.qtgui.Calculators.SldPanel import sldAlgorithm
+from sas.qtgui.Calculators.SldPanel import neutronSldAlgorithm, xraySldAlgorithm
 from sas.qtgui.Utilities.GuiUtils import FormulaValidator
 
@@ -22 +22 @@
 if not QtWidgets.QApplication.instance():
     app = QtWidgets.QApplication(sys.argv)
-
-class SldResultTest(unittest.TestCase):
-    """ Test the simple container class"""
-    def testObjectSize(self):
-        results = SldResult(0.0, 0.0, 0.0, 0.0, 0.0, 0.0,
-                            0.0, 0.0, 0.0, 0.0, 0.0, 0.0)
-        self.assertEqual(sys.getsizeof(results), 56)
 
 
@@ -38 +31 @@
         wavelength = 6.0
         
-        results = sldAlgorithm( molecular_formula,
+        results = neutronSldAlgorithm( molecular_formula,
                                 mass_density,
                                 wavelength)
-        self.assertIsInstance(results, SldResult)
+        #self.assertIsInstance(results, SldResult)
         self.assertAlmostEqual(results.neutron_length, 0.175463, 5)
         self.assertAlmostEqual(results.neutron_inc_xs, 5.365857, 5)
@@ -51 +44 @@
         wavelength = 666.0
         
-        results = sldAlgorithm( molecular_formula,
+        results = neutronSldAlgorithm( molecular_formula,
                                 mass_density,
                                 wavelength)
-        self.assertIsInstance(results, SldResult)
+        #self.assertIsInstance(results, SldResult)
         self.assertAlmostEqual(results.neutron_length,   0.059402, 5)
         self.assertAlmostEqual(results.neutron_inc_xs,   0.145427, 5)
@@ -128 +121 @@
 
         # Assure the mass density field is set
-        #self.assertEqual(self.widget.ui.editNeutronIncXs.text(), '43.4')
         self.assertEqual(self.widget.ui.editNeutronIncXs.text(), '2.89')
-
-        # Reset the widget
-        self.widget.modelReset()
-       
-        self.assertEqual(self.widget.ui.editMolecularFormula.text(), "H2O")
-        self.assertEqual(self.widget.ui.editMassDensity.text(), "1")
-        self.assertEqual(self.widget.ui.editWavelength.text(), "6")
 
     def testHelp(self):

src/sas/qtgui/MainWindow/UnitTesting/DataExplorerTest.py

@@ -740 +740 @@
                                 caption="Save As",
                                 directory='cyl_400_20_out.txt',
-                                filter='Text files (*.txt);;CanSAS 1D files(*.xml)',
+                                filter='Text files (*.txt);;CanSAS 1D files(*.xml);;NXcanSAS files (*.h5)',
                                 parent=None)
         QFileDialog.getSaveFileName.assert_called_once()
@@ -763 +763 @@
                                 caption="Save As",
                                 directory='P123_D2O_10_percent_out.dat',
-                                filter='IGOR/DAT 2D file in Q_map (*.dat)',
+                                filter='IGOR/DAT 2D file in Q_map (*.dat);;NXcanSAS files (*.h5)',
                                 parent=None)
         QFileDialog.getSaveFileName.assert_called_once()

src/sas/qtgui/MainWindow/UnitTesting/GuiManagerTest.py

@@ -147 +147 @@
         """
         self.manager.processVersion = MagicMock()
-        version = {'version'     : '4.2.0',
+        version = {'version'     : '4.2.1',
                    'update_url'  : 'http://www.sasview.org/sasview.latestversion', 
                    'download_url': 'https://github.com/SasView/sasview/releases'}

src/sas/qtgui/Perspectives/Fitting/ComplexConstraint.py

@@ -150 +150 @@
         param2 = self.cbParam2.currentText()
         if source == "cbParam1":
-            self.txtParam.setText(self.tab_names[0] + ":" + param1)
+            self.txtParam.setText(self.cbModel1.currentText() + ":" + param1)
         else:
-            self.txtConstraint.setText(self.tab_names[1] + "." + param2)
+            self.txtConstraint.setText(self.cbModel2.currentText() + "." + param2)
         # Check if any of the parameters are polydisperse
         params_list = [param1, param2]

src/sas/qtgui/Perspectives/Fitting/ConstraintWidget.py

@@ -432 +432 @@
         """
         item = self.tblConstraints.item(row, column)
-        if column != 0: return
-        # Update the tabs for fitting list
-        constraint = self.available_constraints[row]
-        constraint.active = (item.checkState() == QtCore.Qt.Checked)
+        if column == 0:
+            # Update the tabs for fitting list
+            constraint = self.available_constraints[row]
+            constraint.active = (item.checkState() == QtCore.Qt.Checked)
+            return
         # Update the constraint formula
         constraint = self.available_constraints[row]
@@ -470 +471 @@
         self.cmdFit.setStyleSheet('QPushButton {color: black;}')
         self.cmdFit.setText("Fit")
+        self.is_running = False
 
         # Notify the parent about completed fitting
@@ -515 +517 @@
         self.cmdFit.setStyleSheet('QPushButton {color: black;}')
         self.cmdFit.setText("Fit")
+        self.is_running = False
 
         # Notify the parent about completed fitting
@@ -549 +552 @@
         self.cmdFit.setStyleSheet('QPushButton {color: black;}')
         self.cmdFit.setText("Fit")
+        self.is_running = False
 
         # Notify the parent about completed fitting
@@ -769 +773 @@
             item = self.uneditableItem(label)
             item = QtWidgets.QTableWidgetItem(label)
-            item.setFlags(item.flags() ^ QtCore.Qt.ItemIsUserCheckable)
+            # Why was this set to non-interactive??
+            #item.setFlags(item.flags() ^ QtCore.Qt.ItemIsUserCheckable)
             item.setCheckState(QtCore.Qt.Checked)
             self.tblConstraints.insertRow(pos)

src/sas/qtgui/Perspectives/Fitting/FittingUtilities.py

@@ -166 +166 @@
             if cbox:
                 view.setIndexWidget(item2.index(), cbox)
+
         rows.append(row)
 
@@ -202 +203 @@
         item1 = QtGui.QStandardItem(item_name)
         item1.setData(param.name, QtCore.Qt.UserRole)
-        item1.setCheckable(True)
+        item1.setCheckable(False)
         item1.setEditable(False)
 
@@ -219 +220 @@
         # Append to the model and use the combobox, if required
         if None not in (model, view):
+
             if row_num is None:
                 model.appendRow(row)
@@ -224 +226 @@
                 model.insertRow(row_num, row)
                 row_num += 1
-
             if cbox:
+                item1.setCheckable(False)
+                item3.setText("")
+                item4.setText("")
+                item3.setEditable(False)
+                item4.setEditable(False)
                 view.setIndexWidget(item2.index(), cbox)
+            else:
+                item1.setCheckable(True)
 
         rows.append(row)

src/sas/qtgui/Perspectives/Fitting/FittingWidget.py

@@ -1161 +1161 @@
         if category == CATEGORY_STRUCTURE:
             model = None
+        # copy original clipboard
+        cb = QtWidgets.QApplication.clipboard()
+        cb_text = cb.text()
+        # get the screenshot of the current param state
+        self.onCopyToClipboard("")
 
         # Reset parameters to fit
@@ -1168 +1173 @@
 
         self.respondToModelStructure(model=model, structure_factor=structure)
+        # recast the original parameters into the model
+        self.onParameterPaste()
+        # revert to the original clipboard
+        cb.setText(cb_text)
 
     def resetParametersToFit(self):
@@ -2030 +2039 @@
         if not self.data_is_loaded:
             self.createDefaultDataset()
+            self.smearing_widget.updateData(self.data)
         self.calculateQGridForModel()
 
@@ -2870 +2880 @@
         self.createNewIndex(weighted_data)
 
-        # Plot residuals if actual data
-        if not self.data_is_loaded:
-            return
-
         # Calculate difference between return_data and logic.data
         self.chi2 = FittingUtilities.calculateChi2(weighted_data, self.data)
@@ -2879 +2885 @@
         chi2_repr = "---" if self.chi2 is None else GuiUtils.formatNumber(self.chi2, high=True)
         self.lblChi2Value.setText(chi2_repr)
+
+        # Plot residuals if actual data
+        if not self.data_is_loaded:
+            return
 
         residuals_plot = FittingUtilities.plotResiduals(self.data, weighted_data)

src/sas/qtgui/Perspectives/Fitting/OptionsWidget.py

@@ -173 +173 @@
             self.rbWeighting2.setEnabled(True)
             self.rbWeighting2.setChecked(True)
+            self.onWeightingChoice(self.rbWeighting2)
         else:
             self.rbWeighting2.setEnabled(False)
             self.rbWeighting1.setChecked(True)
+            self.onWeightingChoice(self.rbWeighting1)
 
     def updateQRange(self, q_range_min, q_range_max, npts):

src/sas/qtgui/Perspectives/Fitting/SmearingWidget.py

@@ -64 +64 @@
         self.kernel_model = None
         # dQ data variables
-        smear_type = None
-        dq_l = None
-        dq_r = None
+        self.smear_type = None
+        self.dq_l = None
+        self.dq_r = None
+
+        # current pinhole/slot values
+        self.pinhole = 0.0
+        self.slit_height = 0.0
+        self.slit_width = 0.0
+
         # Let only floats in the line edits
         self.txtSmearDown.setValidator(GuiUtils.DoubleValidator())
@@ -109 +115 @@
         Update control elements based on data and model passed
         """
+        # retain the index
+        cur_index = self.cbSmearing.currentIndex()
         self.cbSmearing.clear()
         self.cbSmearing.addItem("None")
@@ -117 +125 @@
         model = self.kernel_model
         self.updateKernelModel(model)
+        # already has the required setup so modify the index
+        self.cbSmearing.setCurrentIndex(cur_index)
 
     def updateKernelModel(self, kernel_model=None):
@@ -184 +194 @@
         # Recalculate the smearing
         index = self.cbSmearing.currentIndex()
+        ## update the backup values based on model choice
+        smearing, accuracy, d_down, d_up = self.state()
+        # don't save the state if dQ Data
+        if smearing == "Custom Pinhole Smear":
+            self.pinhole = d_down
+            self.accuracy = accuracy
+        elif smearing == 'Custom Slit Smear':
+            self.slit_height = d_up
+            self.slit_width = d_down
+
         self.onIndexChange(index)
 
@@ -221 +241 @@
             self.lblSmearUp.setText('<html><head/><body><p>dQ/Q</p></body></html>')
             self.lblUnitUp.setText('%')
+        self.txtSmearUp.setText(str(self.pinhole))
+
         self.txtSmearDown.setEnabled(True)
         self.txtSmearUp.setEnabled(True)
@@ -234 +256 @@
         self.lblUnitDown.setText('<html><head/><body><p>Ã
 <span style=" vertical-align:super;">-1</span></p></body></html>')
+        self.txtSmearDown.setText(str(self.slit_height))
+        self.txtSmearUp.setText(str(self.slit_width))
         self.txtSmearDown.setEnabled(True)
         self.txtSmearUp.setEnabled(True)
@@ -277 +301 @@
             accuracy = str(self.model.item(MODEL.index('ACCURACY')).text())
             try:
-                d_down = float(self.model.item(MODEL.index('PINHOLE_MIN')).text())
+                d_down = float(self.txtSmearUp.text())
             except ValueError:
                 d_down = None
             try:
-                d_up = float(self.model.item(MODEL.index('PINHOLE_MAX')).text())
+                d_up = float(self.txtSmearDown.text())
             except ValueError:
                 d_up = None
@@ -292 +316 @@
         """
         # Update the model -> controls update automatically
-        #if smearing is not None:
-            #self.model.item(MODEL.index('SMEARING')).setText(smearing)
         if accuracy is not None:
             self.model.item(MODEL.index('ACCURACY')).setText(accuracy)
@@ -347 +369 @@
         if d_height is None:
             d_height = 0.0
+
+        self.slit_width = d_width
+        self.slit_height = d_height
 
         if isinstance(self.data, Data2D):

src/sas/qtgui/Perspectives/Fitting/UnitTesting/FittingWidgetTest.py

@@ -205 +205 @@
         model_index = self.widget.cbModel.findText("be_polyelectrolyte")
         self.widget.cbModel.setCurrentIndex(model_index)
+        QtWidgets.qApp.processEvents()
 
         # check the enablement of controls
@@ -242 +243 @@
         self.widget.show()
         # Change the category index so we have some models
-        category_index = self.widget.cbCategory.findText("Shape Independent")
+        category_index = self.widget.cbCategory.findText("Cylinder")
         self.widget.cbCategory.setCurrentIndex(category_index)
         # Change the model to one that supports structure factors
-        model_index = self.widget.cbModel.findText('fractal_core_shell')
+        model_index = self.widget.cbModel.findText('cylinder')
         self.widget.cbModel.setCurrentIndex(model_index)
 
@@ -260 +261 @@
         self.widget.cbStructureFactor.setCurrentIndex(structure_index)
 
-        # We have 3 more param rows now (radius_effective is removed), and a new heading
-        self.assertEqual(self.widget._model_model.rowCount(), rowcount+4)
+        # We have 3 more param rows now (radius_effective is removed), and new headings
+        self.assertEqual(self.widget._model_model.rowCount(), rowcount+7)
 
         # Switch models
@@ -1229 +1230 @@
         model_index = self.widget.cbModel.findText("pringle")
         self.widget.cbModel.setCurrentIndex(model_index)
+        QtWidgets.qApp.processEvents()
 
         # make sure the parameters are different than before

src/sas/qtgui/Plotting/PlotterBase.py

@@ -111 +111 @@
         self.contextMenu = QtWidgets.QMenu(self)
         self.toolbar = NavigationToolbar(self.canvas, self)
+        cid = self.canvas.mpl_connect('resize_event', self.onResize)
+
         layout.addWidget(self.toolbar)
         if not quickplot:
@@ -244 +246 @@
         raise NotImplementedError("Context menu method must be implemented in derived class.")
 
+    def onResize(self, event):
+        """
+        Redefine default resize event
+        """
+        pass
+
     def contextMenuEvent(self, event):
         """

src/sas/qtgui/Utilities/UnitTesting/TabbedModelEditorTest.py

@@ -204 +204 @@
         self.widget.editor_widget.txtEditor.toPlainText = MagicMock(return_value=boring_text)
         self.widget.writeFile = MagicMock()
+        self.widget.plugin_widget.is_python = MagicMock()
         #invoke the method
         self.widget.updateFromEditor()