Changeset 63319b0 in sasview

Timestamp:

Jan 29, 2018 9:33:58 AM (7 years ago)

Author:

Piotr Rozyczko <rozyczko@…>

Branches:

ESS_GUI, ESS_GUI_Docs, ESS_GUI_batch_fitting, ESS_GUI_bumps_abstraction, ESS_GUI_iss1116, ESS_GUI_iss879, ESS_GUI_iss959, ESS_GUI_opencl, ESS_GUI_ordering, ESS_GUI_sync_sascalc

Children:

da9a0722

Parents:

9c0ce68

Message:

unit tests for constraints: FittingWidget?, FittingPerspective?

Location:

src/sas

Files:

• qtgui/Perspectives/Fitting/FittingPerspective.py (modified) (1 diff)
• qtgui/Perspectives/Fitting/FittingWidget.py (modified) (1 diff)
• qtgui/Perspectives/Fitting/UnitTesting/FittingPerspectiveTest.py (modified) (2 diffs)
• qtgui/Perspectives/Fitting/UnitTesting/FittingWidgetTest.py (modified) (6 diffs)
• qtgui/Plotting/UnitTesting/PlotterTest.py (modified) (5 diffs, 1 prop)
• qtgui/Utilities/GuiUtils.py (modified) (1 diff)
• sascalc/fit/AbstractFitEngine.py (modified) (1 diff)

src/sas/qtgui/Perspectives/Fitting/FittingPerspective.py

@@ -212 +212 @@
                 self.dataToFitTab.pop(index_to_delete_str)
 
-        #print "CURRENT dict: ", self.dataToFitTab
-
     def allowBatch(self):
         """

src/sas/qtgui/Perspectives/Fitting/FittingWidget.py

@@ -502 +502 @@
         menu = QtWidgets.QMenu()
         num_rows = len(rows)
+        if num_rows < 1:
+            return menu
         # Select for fitting
         param_string = "parameter " if num_rows==1 else "parameters "

src/sas/qtgui/Perspectives/Fitting/UnitTesting/FittingPerspectiveTest.py

@@ -19 +19 @@
 if not QtWidgets.QApplication.instance():
     app = QtWidgets.QApplication(sys.argv)
+
 
 class FittingPerspectiveTest(unittest.TestCase):
@@ -146 +147 @@
         self.assertEqual(len(self.widget.tabs), 4)
 
+    def testSetBatchData(self):
+        ''' Assure that setting batch data is correct'''
+
+        # Mock the datafromitem() call from FittingWidget
+        data1 = Data1D(x=[1,2], y=[1,2])
+        data2 = Data1D(x=[1,2], y=[1,2])
+        data_batch = [data1, data2]
+        GuiUtils.dataFromItem = MagicMock(return_value=data1)
+
+        item = QtGui.QStandardItem("test")
+        self.widget.setData([item, item], is_batch=True)
+
+        # First tab should not accept data
+        self.assertEqual(len(self.widget.tabs), 2)
+
+        # Add another set of data
+        self.widget.setData([item, item], is_batch=True)
+
+        # Now we should have two batch tabs
+        self.assertEqual(len(self.widget.tabs), 3)
+
+        # Check the names of the new tabs
+        self.assertEqual(self.widget.tabText(1), "BatchPage1")
+        self.assertEqual(self.widget.tabText(2), "BatchPage2")
 
 if __name__ == "__main__":

src/sas/qtgui/Perspectives/Fitting/UnitTesting/FittingWidgetTest.py

@@ -17 +17 @@
 from sas.qtgui.Utilities.GuiUtils import *
 from sas.qtgui.Perspectives.Fitting.FittingWidget import *
+from sas.qtgui.Perspectives.Fitting.Constraints import Constraint
+
 from sas.qtgui.UnitTesting.TestUtils import QtSignalSpy
 
@@ -661 +663 @@
         test_data = Data1D(x=[1,2], y=[1,2])
         item = QtGui.QStandardItem()
-        updateModelItem(item, [test_data], "test")
+        updateModelItem(item, test_data, "test")
         # Force same data into logic
         self.widget.data = item
@@ -687 +689 @@
         # Force same data into logic
         item = QtGui.QStandardItem()
-        updateModelItem(item, [test_data], "test")
+        updateModelItem(item, test_data, "test")
         # Force same data into logic
         self.widget.data = item
@@ -713 +715 @@
         test_data = Data1D(x=[1,2], y=[1,2])
         item = QtGui.QStandardItem()
-        updateModelItem(item, [test_data], "test")
+        updateModelItem(item, test_data, "test")
         # Force same data into logic
         self.widget.data = item
@@ -757 +759 @@
         # Force same data into logic
         item = QtGui.QStandardItem()
-        updateModelItem(item, [test_data], "test")
+        updateModelItem(item, test_data, "test")
         # Force same data into logic
         self.widget.data = item
@@ -1025 +1027 @@
         self.assertNotIn(new_value, self.widget.kernel_module.details[name_modified_param] )
 
+    def testModelContextMenu(self):
+        """
+        Test the right click context menu in the parameter table
+        """
+        # select model: cylinder / cylinder
+        category_index = self.widget.cbCategory.findText("Cylinder")
+        self.widget.cbCategory.setCurrentIndex(category_index)
+
+        model_index = self.widget.cbModel.findText("cylinder")
+        self.widget.cbModel.setCurrentIndex(model_index)
+
+        # no rows selected
+        menu = self.widget.modelContextMenu([])
+        self.assertEqual(len(menu.actions()), 0)
+
+        # 1 row selected
+        menu = self.widget.modelContextMenu([1])
+        self.assertEqual(len(menu.actions()), 4)
+
+        # 2 rows selected
+        menu = self.widget.modelContextMenu([1,3])
+        self.assertEqual(len(menu.actions()), 5)
+
+        # 3 rows selected
+        menu = self.widget.modelContextMenu([1,2,3])
+        self.assertEqual(len(menu.actions()), 4)
+
+        # over 9000
+        with self.assertRaises(AttributeError):
+            menu = self.widget.modelContextMenu([i for i in range(9001)])
+        self.assertEqual(len(menu.actions()), 4)
+
+    def testShowModelContextMenu(self):
+        # select model: cylinder / cylinder
+        category_index = self.widget.cbCategory.findText("Cylinder")
+        self.widget.cbCategory.setCurrentIndex(category_index)
+
+        model_index = self.widget.cbModel.findText("cylinder")
+        self.widget.cbModel.setCurrentIndex(model_index)
+
+        # No selection
+        logging.error = MagicMock()
+        self.widget.showModelDescription = MagicMock()
+        # Show the menu
+        self.widget.showModelContextMenu(QtCore.QPoint(10,20))
+
+        # Assure the description menu is shown
+        self.assertTrue(self.widget.showModelDescription.called)
+        self.assertFalse(logging.error.called)
+
+        # "select" two rows
+        index1 = self.widget.lstParams.model().index(1, 0, QtCore.QModelIndex())
+        index2 = self.widget.lstParams.model().index(2, 0, QtCore.QModelIndex())
+        selection_model = self.widget.lstParams.selectionModel()
+        selection_model.select(index1, selection_model.Select | selection_model.Rows)
+        selection_model.select(index2, selection_model.Select | selection_model.Rows)
+
+        QtWidgets.QMenu.exec_ = MagicMock()
+        logging.error = MagicMock()
+        # Show the menu
+        self.widget.showModelContextMenu(QtCore.QPoint(10,20))
+
+        # Assure the menu is shown
+        self.assertFalse(logging.error.called)
+        self.assertTrue(QtWidgets.QMenu.exec_.called)
+
+    def testShowMultiConstraint(self):
+        """
+        Test the widget update on new multi constraint
+        """
+        # select model: cylinder / cylinder
+        category_index = self.widget.cbCategory.findText("Cylinder")
+        self.widget.cbCategory.setCurrentIndex(category_index)
+
+        model_index = self.widget.cbModel.findText("cylinder")
+        self.widget.cbModel.setCurrentIndex(model_index)
+
+        # nothing selected
+        with self.assertRaises(AssertionError):
+            self.widget.showMultiConstraint()
+
+        # one row selected
+        index = self.widget.lstParams.model().index(1, 0, QtCore.QModelIndex())
+        selection_model = self.widget.lstParams.selectionModel()
+        selection_model.select(index, selection_model.Select | selection_model.Rows)
+        with self.assertRaises(AssertionError):
+            # should also throw
+            self.widget.showMultiConstraint()
+
+        # two rows selected
+        index1 = self.widget.lstParams.model().index(1, 0, QtCore.QModelIndex())
+        index2 = self.widget.lstParams.model().index(2, 0, QtCore.QModelIndex())
+        selection_model = self.widget.lstParams.selectionModel()
+        selection_model.select(index1, selection_model.Select | selection_model.Rows)
+        selection_model.select(index2, selection_model.Select | selection_model.Rows)
+
+        # return non-OK from dialog
+        QtWidgets.QDialog.exec_ = MagicMock()
+        self.widget.showMultiConstraint()
+        # Check the dialog called
+        self.assertTrue(QtWidgets.QDialog.exec_.called)
+
+        # return OK from dialog
+        QtWidgets.QDialog.exec_ = MagicMock(return_value=QtWidgets.QDialog.Accepted)
+        spy = QtSignalSpy(self.widget, self.widget.constraintAddedSignal)
+
+        self.widget.showMultiConstraint()
+
+        # Make sure the signal has been emitted
+        self.assertEqual(spy.count(), 1)
+
+        # Check the argument value - should be row '1'
+        self.assertEqual(spy.called()[0]['args'][0], [1])
+
+    def testGetRowFromName(self):
+        """
+        Helper function for parameter table
+        """
+        # select model: cylinder / cylinder
+        category_index = self.widget.cbCategory.findText("Cylinder")
+        self.widget.cbCategory.setCurrentIndex(category_index)
+
+        model_index = self.widget.cbModel.findText("cylinder")
+        self.widget.cbModel.setCurrentIndex(model_index)
+
+        # several random parameters
+        self.assertEqual(self.widget.getRowFromName('scale'), 0)
+        self.assertEqual(self.widget.getRowFromName('length'), 5)
+
+    def testGetParamNames(self):
+        """
+        Helper function for parameter table
+        """
+        # select model: cylinder / cylinder
+        category_index = self.widget.cbCategory.findText("Cylinder")
+        self.widget.cbCategory.setCurrentIndex(category_index)
+
+        model_index = self.widget.cbModel.findText("cylinder")
+        self.widget.cbModel.setCurrentIndex(model_index)
+
+        cylinder_params = ['scale','background','sld','sld_solvent','radius','length']
+        # assure all parameters are returned
+        self.assertEqual(self.widget.getParamNames(), cylinder_params)
+
+        # Switch to another model
+        model_index = self.widget.cbModel.findText("pringle")
+        self.widget.cbModel.setCurrentIndex(model_index)
+
+        # make sure the parameters are different than before
+        self.assertFalse(self.widget.getParamNames() == cylinder_params)
+
+    def testAddConstraintToRow(self):
+        """
+        Test the constraint row add operation
+        """
+        # select model: cylinder / cylinder
+        category_index = self.widget.cbCategory.findText("Cylinder")
+        self.widget.cbCategory.setCurrentIndex(category_index)
+
+        model_index = self.widget.cbModel.findText("cylinder")
+        self.widget.cbModel.setCurrentIndex(model_index)
+
+        # Create a constraint object
+        const = Constraint(parent=None, value=7.0)
+        row = 2
+
+        spy = QtSignalSpy(self.widget, self.widget.constraintAddedSignal)
+
+        # call the method tested
+        self.widget.addConstraintToRow(constraint=const, row=row)
+
+        # Make sure the signal has been emitted
+        self.assertEqual(spy.count(), 1)
+
+        # Check the argument value - should be row 'row'
+        self.assertEqual(spy.called()[0]['args'][0], [row])
+
+        # Assure the row has the constraint
+        self.assertEqual(self.widget.getConstraintForRow(row), const)
+        # but not complex constraint!
+        self.assertFalse(self.widget.rowHasConstraint(row))
+
+        # assign complex constraint now
+        const = Constraint(parent=None, param='radius', func='5*sld')
+        row = 4
+        # call the method tested
+        self.widget.addConstraintToRow(constraint=const, row=row)
+
+        # Make sure the signal has been emitted
+        self.assertEqual(spy.count(), 2)
+
+        # Check the argument value - should be row 'row'
+        self.assertEqual(spy.called()[1]['args'][0], [row])
+
+        # Assure the row has the constraint
+        self.assertEqual(self.widget.getConstraintForRow(row), const)
+        # and it is a complex constraint
+        self.assertTrue(self.widget.rowHasConstraint(row))
+
+    def testAddSimpleConstraint(self):
+        """
+        Test the constraint add operation
+        """
+        # select model: cylinder / cylinder
+        category_index = self.widget.cbCategory.findText("Cylinder")
+        self.widget.cbCategory.setCurrentIndex(category_index)
+
+        model_index = self.widget.cbModel.findText("cylinder")
+        self.widget.cbModel.setCurrentIndex(model_index)
+
+        # select two rows
+        row1 = 1
+        row2 = 4
+        index1 = self.widget.lstParams.model().index(row1, 0, QtCore.QModelIndex())
+        index2 = self.widget.lstParams.model().index(row2, 0, QtCore.QModelIndex())
+        selection_model = self.widget.lstParams.selectionModel()
+        selection_model.select(index1, selection_model.Select | selection_model.Rows)
+        selection_model.select(index2, selection_model.Select | selection_model.Rows)
+
+        # define the signal spy
+        spy = QtSignalSpy(self.widget, self.widget.constraintAddedSignal)
+
+        # call the method tested
+        self.widget.addSimpleConstraint()
+
+        # Make sure the signal has been emitted
+        self.assertEqual(spy.count(), 2)
+
+        # Check the argument value
+        self.assertEqual(spy.called()[0]['args'][0], [row1])
+        self.assertEqual(spy.called()[1]['args'][0], [row2])
+
+        # Other properties
+        self.assertEqual(self.widget.getConstraintsForModel(), [('background', '0.001'), ('radius', '20')])
+
+    def testDeleteConstraintOnParameter(self):
+        """
+        Test the constraint deletion in model/view
+        """
+        # select model: cylinder / cylinder
+        category_index = self.widget.cbCategory.findText("Cylinder")
+        self.widget.cbCategory.setCurrentIndex(category_index)
+
+        model_index = self.widget.cbModel.findText("cylinder")
+        self.widget.cbModel.setCurrentIndex(model_index)
+
+        # select two rows
+        row1 = 1
+        row2 = 4
+        index1 = self.widget.lstParams.model().index(row1, 0, QtCore.QModelIndex())
+        index2 = self.widget.lstParams.model().index(row2, 0, QtCore.QModelIndex())
+        selection_model = self.widget.lstParams.selectionModel()
+        selection_model.select(index1, selection_model.Select | selection_model.Rows)
+        selection_model.select(index2, selection_model.Select | selection_model.Rows)
+
+        # add constraints
+        self.widget.addSimpleConstraint()
+
+        # deselect the model
+        selection_model.clear()
+
+        # select a single row
+        selection_model.select(index1, selection_model.Select | selection_model.Rows)
+
+        # delete one of the constraints
+        self.widget.deleteConstraintOnParameter(param='background')
+
+        # see that the other constraint is still present
+        self.assertEqual(self.widget.getConstraintsForModel(), [('radius', '20')])
+
+        # kill the other constraint
+        self.widget.deleteConstraint()
+
+        # see that the other constraint is still present
+        self.assertEqual(self.widget.getConstraintsForModel(), [])
+
+    def testGetConstraintForRow(self):
+        """
+        Helper function for parameter table
+        """
+        # tested extensively elsewhere
+        pass
+
+    def testRowHasConstraint(self):
+        """
+        Helper function for parameter table
+        """
+        # select model: cylinder / cylinder
+        category_index = self.widget.cbCategory.findText("Cylinder")
+        self.widget.cbCategory.setCurrentIndex(category_index)
+
+        model_index = self.widget.cbModel.findText("cylinder")
+        self.widget.cbModel.setCurrentIndex(model_index)
+
+        # select two rows
+        row1 = 1
+        row2 = 4
+        index1 = self.widget.lstParams.model().index(row1, 0, QtCore.QModelIndex())
+        index2 = self.widget.lstParams.model().index(row2, 0, QtCore.QModelIndex())
+        selection_model = self.widget.lstParams.selectionModel()
+        selection_model.select(index1, selection_model.Select | selection_model.Rows)
+        selection_model.select(index2, selection_model.Select | selection_model.Rows)
+
+        # add constraints
+        self.widget.addSimpleConstraint()
+
+        con_list = [False, True, False, False, True, False]
+        new_list = []
+        for row in range(self.widget._model_model.rowCount()):
+            new_list.append(self.widget.rowHasConstraint(row))
+
+        self.assertEqual(new_list, con_list)
+
+    def testRowHasActiveConstraint(self):
+        """
+        Helper function for parameter table
+        """
+        # select model: cylinder / cylinder
+        category_index = self.widget.cbCategory.findText("Cylinder")
+        self.widget.cbCategory.setCurrentIndex(category_index)
+
+        model_index = self.widget.cbModel.findText("cylinder")
+        self.widget.cbModel.setCurrentIndex(model_index)
+
+        # select two rows
+        row1 = 1
+        row2 = 4
+        index1 = self.widget.lstParams.model().index(row1, 0, QtCore.QModelIndex())
+        index2 = self.widget.lstParams.model().index(row2, 0, QtCore.QModelIndex())
+        selection_model = self.widget.lstParams.selectionModel()
+        selection_model.select(index1, selection_model.Select | selection_model.Rows)
+        selection_model.select(index2, selection_model.Select | selection_model.Rows)
+
+        # add constraints
+        self.widget.addSimpleConstraint()
+
+        # deactivate the first constraint
+        constraint_objects = self.widget.getConstraintObjectsForModel()
+        constraint_objects[0].active = False
+
+        con_list = [False, False, False, False, True, False]
+        new_list = []
+        for row in range(self.widget._model_model.rowCount()):
+            new_list.append(self.widget.rowHasActiveConstraint(row))
+
+        self.assertEqual(new_list, con_list)
+
+    def testGetConstraintsForModel(self):
+        """
+        Test the constraint getter for constraint texts
+        """
+        # select model: cylinder / cylinder
+        category_index = self.widget.cbCategory.findText("Cylinder")
+        self.widget.cbCategory.setCurrentIndex(category_index)
+
+        model_index = self.widget.cbModel.findText("cylinder")
+        self.widget.cbModel.setCurrentIndex(model_index)
+
+        # no constraints
+        self.assertEqual(self.widget.getConstraintsForModel(),[])
+
+        # select two rows
+        row1 = 1
+        row2 = 4
+        index1 = self.widget.lstParams.model().index(row1, 0, QtCore.QModelIndex())
+        index2 = self.widget.lstParams.model().index(row2, 0, QtCore.QModelIndex())
+        selection_model = self.widget.lstParams.selectionModel()
+        selection_model.select(index1, selection_model.Select | selection_model.Rows)
+        selection_model.select(index2, selection_model.Select | selection_model.Rows)
+
+        # add constraints
+        self.widget.addSimpleConstraint()
+
+        # simple constraints
+        self.assertEqual(self.widget.getConstraintsForModel(), [('background', '0.001'), ('radius', '20')])
+        objects = self.widget.getConstraintObjectsForModel()
+        self.assertEqual(len(objects), 2)
+        self.assertEqual(objects[1].value, '20')
+        self.assertEqual(objects[0].param, 'background')
+
+
+        # add complex constraint
+        const = Constraint(parent=None, param='scale', func='5*sld')
+        row = 0
+        self.widget.addConstraintToRow(constraint=const, row=row)
+        self.assertEqual(self.widget.getConstraintsForModel(),[('scale', '5*sld'), ('background', '0.001'), ('radius', '20')])
+        objects = self.widget.getConstraintObjectsForModel()
+        self.assertEqual(len(objects), 3)
+        self.assertEqual(objects[0].func, '5*sld')
+
+    def testReplaceConstraintName(self):
+        """
+        Test the replacement of constraint moniker
+        """
+        # select model: cylinder / cylinder
+        category_index = self.widget.cbCategory.findText("Cylinder")
+        self.widget.cbCategory.setCurrentIndex(category_index)
+
+        model_index = self.widget.cbModel.findText("cylinder")
+        self.widget.cbModel.setCurrentIndex(model_index)
+
+        old_name = 'M5'
+        new_name = 'poopy'
+        # add complex constraint
+        const = Constraint(parent=None, param='scale', func='%s.5*sld'%old_name)
+        row = 0
+        self.widget.addConstraintToRow(constraint=const, row=row)
+
+        # Replace 'm5' with 'poopy'
+        self.widget.replaceConstraintName(old_name, new_name)
+
+        self.assertEqual(self.widget.getConstraintsForModel(),[('scale', 'poopy.5*sld')])
+
 
 if __name__ == "__main__":

src/sas/qtgui/Plotting/UnitTesting/PlotterTest.py

@@ -50 +50 @@
         self.assertEqual(self.plotter.data, self.data)
         self.assertEqual(self.plotter._title, self.data.name)
-        self.assertEqual(self.plotter.xLabel, "$()$")
-        self.assertEqual(self.plotter.yLabel, "$()$")
+        self.assertEqual(self.plotter.xLabel, "")
+        self.assertEqual(self.plotter.yLabel, "")
 
     def testPlotWithErrors(self):
@@ -91 +91 @@
         self.plotter.data = data
         self.plotter.show()
-        FigureCanvas.draw = MagicMock()
+        FigureCanvas.draw_idle = MagicMock()
 
         self.plotter.plot(hide_error=True)
@@ -97 +97 @@
         self.assertEqual(self.plotter.ax.get_xscale(), 'linear')
         self.assertEqual(self.plotter.ax.get_yscale(), 'linear')
-        self.assertTrue(FigureCanvas.draw.called)
+        self.assertTrue(FigureCanvas.draw_idle.called)
 
     def testCreateContextMenuQuick(self):
@@ -200 +200 @@
         self.plotter.addText.exec_ = MagicMock(return_value = QtWidgets.QDialog.Accepted)
         # Add text to graph
+        self.plotter.x_click = 1.0
+        self.plotter.y_click = 5.0
         self.plotter.onAddText()
         self.plotter.show()
@@ -394 +396 @@
         xl = self.plotter.ax.xaxis.label.get_text()
         yl = self.plotter.ax.yaxis.label.get_text()
-        self.assertEqual(xl, "$()$")
-        self.assertEqual(yl, "$()$")
+        self.assertEqual(xl, "")
+        self.assertEqual(yl, "")
 
         # Prepare new data

src/sas/qtgui/Utilities/GuiUtils.py

@@ -325 +325 @@
     """
     assert isinstance(item, QtGui.QStandardItem)
-    assert isinstance(update_data, list)
+    #assert isinstance(update_data, list)
 
     # Add the actual Data1D/Data2D object

src/sas/sascalc/fit/AbstractFitEngine.py

@@ -300 +300 @@
             self.qmax = math.sqrt(x_max * x_max + y_max * y_max)
         ## new error image for fitting purpose
-        if self.err_data is None or self.err_data == []:
+        if self.err_data is None or not self.err_data:
             self.res_err_data = np.ones(len(self.data))
         else: