Changeset 60e20d8 in sasview

Timestamp:

Mar 26, 2019 8:28:41 AM (6 years ago)

Author:

GitHub <noreply@…>

Branches:

ESS_GUI, ESS_GUI_bumps_abstraction, ESS_GUI_iss1116, ESS_GUI_opencl

Children:

bad4a52, 5d14851a

Parents:

14e1ff0 (diff), f810eb6 (diff)
Note: this is a merge changeset, the changes displayed below correspond to the merge itself.
Use the (diff) links above to see all the changes relative to each parent.

git-author:

Piotr Rozyczko <piotr.rozyczko@…> (03/26/19 08:28:41)

git-committer:

GitHub <noreply@…> (03/26/19 08:28:41)

Message:

Merge pull request #214 from rprospero/Sasview-1127

Sasview 1127 - Changing fit parameters reverts y axis back to linear

Location:

src/sas/qtgui

Files:

• Plotting/Plotter.py (modified) (1 diff)
• Perspectives/Fitting/ConstraintWidget.py (modified) (7 diffs)
• Perspectives/Fitting/FittingPerspective.py (modified) (1 diff)

src/sas/qtgui/Plotting/Plotter.py

@@ -420 +420 @@
         This effectlvely refreshes the chart with changes to one of its plots
         """
+
+        # Pull the current transform settings from the old plot
+        selected_plot = self.plot_dict[id]
+        new_plot.xtransform = selected_plot.xtransform
+        new_plot.ytransform = selected_plot.ytransform
+
         self.removePlot(id)
         self.plot(data=new_plot)

src/sas/qtgui/Perspectives/Fitting/ConstraintWidget.py

@@ -128 +128 @@
         self.is_chain_fitting = False
 
+        # Is the fit job running?
+        self.is_running = False
+        self.calc_fit = None
+
         # Remember previous content of modified cell
         self.current_cell = ""
@@ -257 +261 @@
         Perform the constrained/simultaneous fit
         """
+        # Stop if we're running
+        if self.is_running:
+            self.is_running = False
+            #re-enable the Fit button
+            self.cmdFit.setStyleSheet('QPushButton {color: black;}')
+            self.cmdFit.setText("Fit")
+            # stop the fitpages
+            self.calc_fit.stop()
+            return
+
         # Find out all tabs to fit
         tabs_to_fit = self.getTabsForFit()
@@ -310 +324 @@
 
         # new fit thread object
-        calc_fit = FitThread(handler=handler,
+        self.calc_fit = FitThread(handler=handler,
                              fn=sim_fitter_list,
                              batch_inputs=batch_inputs,
@@ -321 +335 @@
         if LocalConfig.USING_TWISTED:
             # start the trhrhread with twisted
-            calc_thread = threads.deferToThread(calc_fit.compute)
-            calc_thread.addCallback(completefn)
-            calc_thread.addErrback(self.onFitFailed)
+            self.calc_fit = threads.deferToThread(self.calc_fit.compute)
+            self.calc_fit.addCallback(completefn)
+            self.calc_fit.addErrback(self.onFitFailed)
         else:
             # Use the old python threads + Queue
-            calc_fit.queue()
-            calc_fit.ready(2.5)
-
-
-        #disable the Fit button
+            self.calc_fit.queue()
+            self.calc_fit.ready(2.5)
+
+        # modify the Fit button
         self.cmdFit.setStyleSheet('QPushButton {color: red;}')
-        self.cmdFit.setText('Running...')
+        self.cmdFit.setText('Stop fit')
         self.parent.communicate.statusBarUpdateSignal.emit('Fitting started...')
-        self.cmdFit.setEnabled(False)
+        self.is_running = True
 
     def onHelp(self):
@@ -457 +470 @@
         self.cmdFit.setStyleSheet('QPushButton {color: black;}')
         self.cmdFit.setText("Fit")
-        self.cmdFit.setEnabled(True)
 
         # Notify the parent about completed fitting
@@ -503 +515 @@
         self.cmdFit.setStyleSheet('QPushButton {color: black;}')
         self.cmdFit.setText("Fit")
-        self.cmdFit.setEnabled(True)
 
         # Notify the parent about completed fitting
@@ -538 +549 @@
         self.cmdFit.setStyleSheet('QPushButton {color: black;}')
         self.cmdFit.setText("Fit")
-        self.cmdFit.setEnabled(True)
 
         # Notify the parent about completed fitting

src/sas/qtgui/Perspectives/Fitting/FittingPerspective.py

@@ -406 +406 @@
                 tab_object.enableInteractiveElements()
 
-        pass
-
     def getCurrentStateAsXml(self):
         """