Changeset 34f13a83 in sasview for src/sas/qtgui

Timestamp:

Sep 25, 2018 9:50:18 AM (6 years ago)

Author:

Piotr Rozyczko <piotr.rozyczko@…>

Branches:

ESS_GUI, ESS_GUI_batch_fitting, ESS_GUI_bumps_abstraction, ESS_GUI_iss1116, ESS_GUI_opencl, ESS_GUI_ordering, ESS_GUI_sync_sascalc

Children:

cb39d66

Parents:

624c8747

Message:

Disabled native matplotlib toolbar due to bugs in its 2.1.0
implementation. Will revisit when upgrading to 3.0.
SASVIEW-1103, SASVIEW-1106

Location:

src/sas/qtgui/Plotting

Files:

• Plotter.py (modified) (1 diff)
• Plotter2D.py (modified) (1 diff)
• PlotterBase.py (modified) (4 diffs)
• UnitTesting/Plotter2DTest.py (modified) (2 diffs)
• UnitTesting/PlotterBaseTest.py (modified) (2 diffs)
• UnitTesting/PlotterTest.py (modified) (2 diffs)

src/sas/qtgui/Plotting/Plotter.py

@@ -75 +75 @@
         if isinstance(data, Data1D):
             self.data = data
-        if not self._data or data is None:
+
+        if not self._data:
             return
 

src/sas/qtgui/Plotting/Plotter2D.py

@@ -95 +95 @@
             self.data = data
 
-        if not self._data or data is None:
+        if not self._data:
             return
 

src/sas/qtgui/Plotting/PlotterBase.py

@@ -114 +114 @@
         if not quickplot:
             # Add the toolbar
-            self.toolbar.show()
+            # self.toolbar.show()
+            self.toolbar.hide() # hide for the time being
             # Notify PlotHelper about the new plot
             self.upatePlotHelper()
@@ -220 +221 @@
         self.actionPrintImage = self.contextMenu.addAction("Print Image")
         self.actionCopyToClipboard = self.contextMenu.addAction("Copy to Clipboard")
-        self.contextMenu.addSeparator()
-        self.actionToggleMenu = self.contextMenu.addAction("Toggle Navigation Menu")
+        #self.contextMenu.addSeparator()
+        #self.actionToggleMenu = self.contextMenu.addAction("Toggle Navigation Menu")
         self.contextMenu.addSeparator()
 
@@ -229 +230 @@
         self.actionPrintImage.triggered.connect(self.onImagePrint)
         self.actionCopyToClipboard.triggered.connect(self.onClipboardCopy)
-        self.actionToggleMenu.triggered.connect(self.onToggleMenu)
+        #self.actionToggleMenu.triggered.connect(self.onToggleMenu)
 
     def createContextMenu(self):
@@ -381 +382 @@
         Toggle navigation menu visibility in the chart
         """
-        if self.toolbar.isVisible():
-            self.toolbar.hide()
-        else:
-            self.toolbar.show()
+        self.toolbar.hide()
+        # Current toolbar menu is too buggy.
+        # Comment out until we support 3.x, then recheck.
+        #if self.toolbar.isVisible():
+        #    self.toolbar.hide()
+        #else:
+        #    self.toolbar.show()
 
     def offset_graph(self):

src/sas/qtgui/Plotting/UnitTesting/Plotter2DTest.py

@@ -146 +146 @@
         self.plotter.createContextMenuQuick()
         actions = self.plotter.contextMenu.actions()
-        self.assertEqual(len(actions), 9)
+        self.assertEqual(len(actions), 7)
 
         # Trigger Print Image and make sure the method is called
@@ -158 +158 @@
 
         # Trigger Toggle Grid and make sure the method is called
-        self.assertEqual(actions[6].text(), "Toggle Grid On/Off")
+        self.assertEqual(actions[4].text(), "Toggle Grid On/Off")
         self.plotter.ax.grid = MagicMock()
+        actions[4].trigger()
+        self.assertTrue(self.plotter.ax.grid.called)
+
+        # Trigger Change Scale and make sure the method is called
+        self.assertEqual(actions[6].text(), "Toggle Linear/Log Scale")
+        FigureCanvas.draw_idle = MagicMock()
         actions[6].trigger()
-        self.assertTrue(self.plotter.ax.grid.called)
-
-        # Trigger Change Scale and make sure the method is called
-        self.assertEqual(actions[8].text(), "Toggle Linear/Log Scale")
-        FigureCanvas.draw_idle = MagicMock()
-        actions[8].trigger()
         self.assertTrue(FigureCanvas.draw_idle.called)
 

src/sas/qtgui/Plotting/UnitTesting/PlotterBaseTest.py

@@ -124 +124 @@
 
         actions = self.plotter.contextMenu.actions()
-        self.assertEqual(len(actions), 6)
+        self.assertEqual(len(actions), 4)
 
         # Trigger Print Image and make sure the method is called
@@ -147 +147 @@
         self.assertTrue(self.clipboard_called)
 
-        # Trigger toggle navigation bar and make sure the method is called
-        self.assertEqual(actions[4].text(), "Toggle Navigation Menu")
-        isShown = self.plotter.toolbar.isVisible()
-        self.assertTrue(isShow)
-        actions[4].trigger()
-        isShown = self.plotter.toolbar.isVisible()
-        self.assertFalse(isShow)
-        actions[4].trigger()
-        isShown = self.plotter.toolbar.isVisible()
-        self.assertTrue(isShow)
+        ## Trigger toggle navigation bar and make sure the method is called
+        #self.assertEqual(actions[4].text(), "Toggle Navigation Menu")
+        #isShown = self.plotter.toolbar.isVisible()
+        #self.assertTrue(isShow)
+        #actions[4].trigger()
+        #isShown = self.plotter.toolbar.isVisible()
+        #self.assertFalse(isShow)
+        #actions[4].trigger()
+        #isShown = self.plotter.toolbar.isVisible()
+        #self.assertTrue(isShow)
 
 

src/sas/qtgui/Plotting/UnitTesting/PlotterTest.py

@@ -103 +103 @@
         self.plotter.createContextMenuQuick()
         actions = self.plotter.contextMenu.actions()
-        self.assertEqual(len(actions), 9)
+        self.assertEqual(len(actions), 7)
 
         # Trigger Print Image and make sure the method is called
@@ -115 +115 @@
 
         # Trigger Toggle Grid and make sure the method is called
-        self.assertEqual(actions[6].text(), "Toggle Grid On/Off")
+        self.assertEqual(actions[4].text(), "Toggle Grid On/Off")
         self.plotter.ax.grid = MagicMock()
+        actions[4].trigger()
+        self.assertTrue(self.plotter.ax.grid.called)
+
+        # Trigger Change Scale and make sure the method is called
+        self.assertEqual(actions[6].text(), "Change Scale")
+        self.plotter.properties.exec_ = MagicMock(return_value=QtWidgets.QDialog.Rejected)
         actions[6].trigger()
-        self.assertTrue(self.plotter.ax.grid.called)
-
-        # Trigger Change Scale and make sure the method is called
-        self.assertEqual(actions[8].text(), "Change Scale")
-        self.plotter.properties.exec_ = MagicMock(return_value=QtWidgets.QDialog.Rejected)
-        actions[8].trigger()
         self.assertTrue(self.plotter.properties.exec_.called)