Changeset 1abcb04 in sasview for guiframe/local_perspectives/plotting

Timestamp:

Jun 5, 2009 9:08:48 PM (15 years ago)

Author:

Mathieu Doucet <doucetm@…>

Branches:

master, ESS_GUI, ESS_GUI_Docs, ESS_GUI_batch_fitting, ESS_GUI_bumps_abstraction, ESS_GUI_iss1116, ESS_GUI_iss879, ESS_GUI_iss959, ESS_GUI_opencl, ESS_GUI_ordering, ESS_GUI_sync_sascalc, costrafo411, magnetic_scatt, release-4.1.1, release-4.1.2, release-4.2.2, release_4.0.1, ticket-1009, ticket-1094-headless, ticket-1242-2d-resolution, ticket-1243, ticket-1249, ticket885, unittest-saveload

Children:

410aad8

Parents:

7d8094b

Message:

guiframe: modified the dataFitting.Data1D to be a child class of DataLoader?.data_info.Data1D, as was originally designed. Added lots of TODOs for refactoring. Inserted a call to bridge the data of the newly defined Data1D to the output of DataLoader?. The data_loader module needs a lot of work.

File:

• guiframe/local_perspectives/plotting/Plotter1D.py (modified) (3 diffs)

guiframe/local_perspectives/plotting/Plotter1D.py

@@ -419 +419 @@
         """
             Save 1D  Data to  XML file
+            
+            TODO: Refactor and remove this method. See TODO in _onSave.
+            
             @param evt: Menu event
         """
@@ -439 +442 @@
         """
             Save file as txt
+            
+            TODO: Refactor and remove this method. See TODO in _onSave.
         """
         data = self.plots[self.graph.selected_plottable]
@@ -495 +500 @@
                 path = dlg.GetPath()
                 mypath = os.path.basename(path)
+                
+                #TODO: This is bad design. The DataLoader is designed to recognize extensions.
+                # It should be a simple matter of calling the .save(file, data, '.xml') method
+                # of the DataLoader.loader.Loader class. 
+                
                 if os.path.splitext(mypath)[1].lower() ==".txt":
                     self._onsaveTXT(path)