Changes in / [91552b5:1176137] in sasview

Files:

• build_tools/requirements.txt (modified) (1 diff)
• setup.py (modified) (1 diff)
• src/sas/sascalc/dataloader/file_reader_base_class.py (modified) (4 diffs)
• src/sas/sascalc/dataloader/loader.py (modified) (2 diffs)
• src/sas/sasgui/guiframe/local_perspectives/data_loader/data_loader.py (modified) (5 diffs)
• test/sasdataloader/test/FEB18012.ASC (added)
• test/sasdataloader/test/test_data/TestExtensions (added)
• test/sasdataloader/test/test_data/TestExtensions.asc (added)
• test/sasdataloader/test/test_data/TestExtensions.notxml (added)
• test/sasdataloader/test/test_data/TestExtensions.nxs (added)
• test/sasdataloader/test/test_data/TestExtensions.xml (added)
• test/sasdataloader/test/utest_generic_file_reader_class.py (modified) (3 diffs)

build_tools/requirements.txt

@@ -3 +3 @@
 pylint
 unittest-xml-reporting==1.10.0
-pyparsing==1.5.5
+pyparsing>=2.0
 html5lib==0.95
 reportlab==2.5

setup.py

@@ -402 +402 @@
 
 required = [
-    'bumps>=0.7.5.9', 'periodictable>=1.5.0', 'pyparsing<2.0.0',
+    'bumps>=0.7.5.9', 'periodictable>=1.5.0', 'pyparsing>=2.0.0',
 
     # 'lxml>=2.2.2',

src/sas/sascalc/dataloader/file_reader_base_class.py

@@ -31 +31 @@
 FIELDS_2D = ('data', 'qx_data', 'qy_data', 'q_data', 'err_data',
                  'dqx_data', 'dqy_data', 'mask')
-
+DEPRECATION_MESSAGE = ("\rThe extension of this file suggests the data set migh"
+                       "t not be fully reduced. Support for the reader associat"
+                       "ed with this file type has been removed. An attempt to "
+                       "load the file was made, but, should it be successful, "
+                       "SasView cannot guarantee the accuracy of the data.")
 
 class FileReader(object):
@@ -40 +44 @@
     # List of allowed extensions
     ext = ['.txt']
+    # Deprecated extensions
+    deprecated_extensions = ['.asc', '.nxs']
     # Bypass extension check and try to load anyway
     allow_all = False
@@ -87 +93 @@
                     if not self.f_open.closed:
                         self.f_open.close()
+                    if any(filepath.lower().endswith(ext) for ext in
+                           self.deprecated_extensions):
+                        self.handle_error_message(DEPRECATION_MESSAGE)
                     if len(self.output) > 0:
                         # Sort the data that's been loaded
@@ -146 +155 @@
         else:
             logger.warning(msg)
+            raise NoKnownLoaderException(msg)
 
     def send_to_output(self):

src/sas/sascalc/dataloader/loader.py

@@ -90 +90 @@
             ascii_loader = ascii_reader.Reader()
             return ascii_loader.read(path)
+        except NoKnownLoaderException:
+            pass  # Try the Cansas XML reader
         except DefaultReaderException:
             pass  # Loader specific error to try the cansas XML reader
@@ -100 +102 @@
             cansas_loader = cansas_reader.Reader()
             return cansas_loader.read(path)
+        except NoKnownLoaderException:
+            pass  # Try the NXcanSAS reader
         except DefaultReaderException:
             pass  # Loader specific error to try the NXcanSAS reader

src/sas/sasgui/guiframe/local_perspectives/data_loader/data_loader.py

@@ -185 +185 @@
             try:
                 message = "Loading {}...\n".format(p_file)
-                self.load_update(output=output, message=message, info="info")
+                self.load_update(message=message, info="info")
                 temp = self.loader.load(p_file, format)
                 if not isinstance(temp, list):
@@ -201 +201 @@
                         else:
                             file_errors[basename] = [error_message]
-                        self.load_update(output=output,
-                            message=error_message, info="warning")
-
-                self.load_update(output=output,
-                message="Loaded {}\n".format(p_file),
-                info="info")
+
+                self.load_update(message="Loaded {}\n".format(p_file),
+                                 info="info")
 
             except NoKnownLoaderException as e:
                 exception_occurred = True
-                logger.error(e.message)
-
                 error_message = "Loading data failed!\n" + e.message
-                self.load_update(output=None, message=e.message, info="warning")
+                self.load_complete(output=None,
+                                   message=error_message,
+                                   info="warning")
 
             except Exception as e:
                 exception_occurred = True
-                logger.error(e.message)
-
                 file_err = "The Data file you selected could not be "
                 file_err += "loaded.\nMake sure the content of your file"
@@ -225 +220 @@
                 file_err += " following:\n"
                 file_err += e.message
-                file_errors[basename] = [file_err]
+                self.load_complete(output=None,
+                                   message=file_err,
+                                   info="error")
 
         if len(file_errors) > 0:
             error_message = ""
             for filename, error_array in file_errors.iteritems():
-                error_message += "The following errors occured whilst "
+                error_message += "The following issues were found whilst "
                 error_message += "loading {}:\n".format(filename)
                 for message in error_array:
                     error_message += message + "\n"
-                error_message += "\n"
-            if not exception_occurred: # Some data loaded but with errors
-                self.load_update(output=output, message=error_message, info="error")
-
-        if not exception_occurred: # Everything loaded as expected
+                error_message = error_message[:-1]
+            self.load_complete(output=output,
+                               message=error_message,
+                               info="error")
+
+        elif not exception_occurred: # Everything loaded as expected
             self.load_complete(output=output, message="Loading data complete!",
                                info="info")
@@ -244 +242 @@
             self.load_complete(output=None, message=error_message, info="error")
 
-
-    def load_update(self, output=None, message="", info="warning"):
+    def load_update(self, message="", info="warning"):
         """
         print update on the status bar
         """
         if message != "":
-            wx.PostEvent(self.parent, StatusEvent(status=message, info=info,
+            wx.PostEvent(self.parent, StatusEvent(status=message,
+                                                  info=info,
                                                   type="progress"))
 
@@ -257 +255 @@
          post message to status bar and return list of data
         """
-        wx.PostEvent(self.parent, StatusEvent(status=message, info=info,
+        wx.PostEvent(self.parent, StatusEvent(status=message,
+                                              info=info,
                                               type="stop"))
         if output is not None:

test/sasdataloader/test/utest_generic_file_reader_class.py

@@ -8 +8 @@
 import numpy as np
 
-from sas.sascalc.dataloader.data_info import DataInfo, plottable_1D
+from sas.sascalc.dataloader.data_info import DataInfo, plottable_1D, Data1D
+from sas.sascalc.dataloader.loader import Loader
+from sas.sascalc.dataloader.loader_exceptions import NoKnownLoaderException
 from sas.sascalc.dataloader.file_reader_base_class import FileReader
 
@@ -24 +26 @@
         self.bad_file = find("ACB123.txt")
         self.good_file = find("123ABC.txt")
+        self.generic_reader = Loader()
+        self.deprecated_file_type = find("FEB18012.ASC")
 
     def test_bad_file_path(self):
-        output = self.reader.read(self.bad_file)
-        self.assertEqual(output, [])
+        self.assertRaises(NoKnownLoaderException, self.reader.read,
+                          self.bad_file)
 
     def test_good_file_path(self):
@@ -36 +40 @@
         self.assertEqual(len(output), 1)
         self.assertEqual(output[0].meta_data["blah"], '123ABC exists!')
+
+    def test_old_file_types(self):
+        f = self.generic_reader.load(self.deprecated_file_type)
+        last_f = f[0]
+        if hasattr(last_f, "errors"):
+            self.assertEquals(len(last_f.errors), 1)
+        else:
+            self.fail("Errors did not propogate to the file properly.")
+
+    def test_same_file_unknown_extensions(self):
+        # Five files, all with the same content, but different file extensions
+        no_ext = find("test_data//TestExtensions")
+        not_xml = find("test_data//TestExtensions.notxml")
+        # Deprecated extensions
+        asc_dep = find("test_data//TestExtensions.asc")
+        nxs_dep = find("test_data//TestExtensions.nxs")
+        # Native extension as a baseline
+        xml_native = find("test_data//TestExtensions.xml")
+        # Load the files and check contents
+        no_ext_load = self.generic_reader.load(no_ext)
+        asc_load = self.generic_reader.load(asc_dep)
+        nxs_load = self.generic_reader.load(nxs_dep)
+        not_xml_load = self.generic_reader.load(not_xml)
+        xml_load = self.generic_reader.load(xml_native)
+        self.check_unknown_extension(no_ext_load[0])
+        self.check_unknown_extension(asc_load[0])
+        self.check_unknown_extension(nxs_load[0])
+        self.check_unknown_extension(not_xml_load[0])
+        self.check_unknown_extension(xml_load[0])
+        # Be sure the deprecation warning is passed with the file
+        self.assertEquals(len(asc_load[0].errors), 1)
+        self.assertEquals(len(nxs_load[0].errors), 1)
+
+    def check_unknown_extension(self, data):
+        self.assertTrue(isinstance(data, Data1D))
+        self.assertEquals(len(data.x), 138)
+        self.assertEquals(data.sample.ID, "TK49 c10_SANS")
+        self.assertEquals(data.meta_data["loader"], "CanSAS XML 1D")
 
     def tearDown(self):