Changeset 0fe7e5b in sasview

Timestamp:

Aug 21, 2018 6:29:41 AM (6 years ago)

Author:

Torin Cooper-Bennun <torin.cooper-bennun@…>

Branches:

ESS_GUI, ESS_GUI_batch_fitting, ESS_GUI_bumps_abstraction, ESS_GUI_iss1116, ESS_GUI_iss879, ESS_GUI_opencl, ESS_GUI_ordering, ESS_GUI_sync_sascalc

Children:

c0de493

Parents:

e11106e

Message:

remove redundant intermediate plots when a new model is selected that does not plot them

Location:

src/sas/qtgui

Files:

• Perspectives/Fitting/FittingWidget.py (modified) (3 diffs)
• Utilities/GuiUtils.py (modified) (1 diff)

src/sas/qtgui/Perspectives/Fitting/FittingWidget.py

@@ -2227 +2227 @@
         """
         fitted_data = self.logic.new1DPlot(return_data, self.tab_id)
-        self.calculateResiduals(fitted_data)
+        residuals = self.calculateResiduals(fitted_data)
         self.model_data = fitted_data
+
+        new_plots = [fitted_data, residuals]
 
         # Create plots for intermediate product data
@@ -2235 +2237 @@
             pq_data.symbol = "Line"
             self.createNewIndex(pq_data)
+            new_plots.append(pq_data)
         if sq_data is not None:
             sq_data.symbol = "Line"
             self.createNewIndex(sq_data)
+            new_plots.append(sq_data)
+
+        if self.data_is_loaded:
+            GuiUtils.deleteRedundantPlots(self.all_data[self.data_index], new_plots)
 
     def complete2D(self, return_data):
@@ -2273 +2280 @@
         residuals_plot.id = "Residual " + residuals_plot.id
         self.createNewIndex(residuals_plot)
+        return residuals_plot
 
     def onCategoriesChanged(self):

src/sas/qtgui/Utilities/GuiUtils.py

@@ -292 +292 @@
     # Append the new row to the main item
     item.appendRow(checkbox_item)
+
+def deleteRedundantPlots(item, new_plots):
+    """
+    Checks all plots that are children of the given item; if any have an ID or name not included in new_plots,
+    it is deleted. Useful for e.g. switching from P(Q)S(Q) to P(Q); this would remove the old S(Q) plot.
+
+    Ensure that new_plots contains ALL the relevant plots(!!!)
+    """
+    assert isinstance(item, QtGui.QStandardItem)
+
+    names = [p.name for p in new_plots if p.name is not None]
+    ids = [p.id for p in new_plots if p.id is not None]
+
+    items_to_delete = []
+
+    for index in range(item.rowCount()):
+        plot_item = item.child(index)
+        if plot_item.isCheckable():
+            plot_data = plot_item.child(0).data()
+            if (plot_data.id is not None) and (plot_data.id not in ids) and (plot_data.name not in names):
+                items_to_delete.append(plot_item)
+
+    for plot_item in items_to_delete:
+        item.removeRow(plot_item.row())
 
 class HashableStandardItem(QtGui.QStandardItem):