Changes in src/sas/sasgui/perspectives/fitting/simfitpage.py [24d9e84:00f7ff1] in sasview

File:

• src/sas/sasgui/perspectives/fitting/simfitpage.py (modified) (6 diffs)

src/sas/sasgui/perspectives/fitting/simfitpage.py

@@ -1 +1 @@
 """
-    Simultaneous or Batch fit page
+    Simultaneous fit page
 """
-# Note that this is used for both Simultaneous/Constrained fit AND for
-# combined batch fit.  This is done through setting of the batch_on parameter.
-# There are the a half dozen or so places where an if statement is used as in
-# if not batch_on:
-#     xxxx
-# else:
-#     xxxx
-# This is just wrong but dont have time to fix this go. Proper approach would be
-# to strip all parts of the code that depend on batch_on and create the top
-# level class from which a contrained/simultaneous fit page and a combined
-# batch page inherit.
-#
-#            04/09/2017   --PDB
-
 import sys
 from collections import namedtuple
@@ -163 +149 @@
         :return: None
         """
-        init_map = {}
-        final_map = {}
+        model_map = {}
         # Process each model and associate old M# with new M#
         i = 0
@@ -178 +163 @@
                     check = bool(saved_model.pop('checked'))
                     self.model_list[i][0].SetValue(check)
-                    inter_id = str(i)*5
-                    init_map[saved_model.pop('fit_page_source')] = inter_id
-                    final_map[inter_id] = model[3].name
-                    check = bool(saved_model.pop('checked'))
-                    self.model_list[i][0].SetValue(check)
                     break
             i += 1
@@ -199 +179 @@
                 param = item.pop('param_cbox')
                 equality = item.pop('egal_txt')
-                for key, value in init_map.items():
-                    model_cbox = model_cbox.replace(key, value)
-                    constraint_value = constraint_value.replace(key, value)
-                for key, value in final_map.items():
-                    model_cbox = model_cbox.replace(key, value)
-                    constraint_value = constraint_value.replace(key, value)
+                for key, value in model_map.iteritems():
+                    model_cbox.replace(key, value)
+                    constraint_value.replace(key, value)
 
                 self.constraints_list[index][0].SetValue(model_cbox)
@@ -479 +456 @@
         # General Help button
         self.btHelp = wx.Button(self, wx.ID_HELP, 'HELP')
-        if self.batch_on:
-            self.btHelp.SetToolTipString("Combined Batch Fitting help.")
-        else:
-            self.btHelp.SetToolTipString("Simultaneous/Constrained Fitting help.")
+        self.btHelp.SetToolTipString("Simultaneous/Constrained Fitting help.")
         self.btHelp.Bind(wx.EVT_BUTTON, self._on_help)
 
@@ -609 +583 @@
     """
         _TreeLocation = "user/sasgui/perspectives/fitting/fitting_help.html"
-        if not self.batch_on:
-            _PageAnchor = "#simultaneous-fit-mode"
-            _doc_viewer = DocumentationWindow(self, self.ID_DOC, _TreeLocation,
+        _PageAnchor = "#simultaneous-fit-mode"
+        _doc_viewer = DocumentationWindow(self, self.ID_DOC, _TreeLocation,
                                           _PageAnchor,
                                           "Simultaneous/Constrained Fitting Help")
-        else:
-            _PageAnchor = "#combined-batch-fit-mode"
-            _doc_viewer = DocumentationWindow(self, self.ID_DOC, _TreeLocation,
-                                          _PageAnchor,
-                                          "Combined Batch Fit Help")
 
     def set_manager(self, manager):