source: sasview/guitools/requirements.txt @ 5789654

ESS_GUIESS_GUI_DocsESS_GUI_batch_fittingESS_GUI_bumps_abstractionESS_GUI_iss1116ESS_GUI_iss879ESS_GUI_iss959ESS_GUI_openclESS_GUI_orderingESS_GUI_sync_sascalccostrafo411magnetic_scattrelease-4.1.1release-4.1.2release-4.2.2release_4.0.1ticket-1009ticket-1094-headlessticket-1242-2d-resolutionticket-1243ticket-1249ticket885unittest-saveload
Last change on this file since 5789654 was 5789654, checked in by Gervaise Alina <gervyh@…>, 16 years ago

modied fitdialog property dialog added fittings , modified plottables

  • Property mode set to 100644
File size: 2.9 KB
Line 
1- BUGS
2
3  1- [DONE] After fitting, the fit panel is not updated with the output values of the fit.
4 
5  2- [DONE] Do this:
6      a) load the file line_in_x2_y.txt
7      b) fit a straight line, close the Fit Dialog
8      c) change the scale using the "Properties" menu to x vs y (linear vs linear)
9      You will see an exception that should be fixed.
10
11  3-  [DONE] Load the file line_in_x2_y.txt in miniView. Select x^2 and y for the scales. Fit it.
12      a) The fit range is wrong, it's not update for the X^2 view.
13      b) the fit result is wrong
14      c) Even if you update the range, the fit and the plots are wrong.
15     
16  4- [DONE]At the python command prompt, try:
17       from sans.guitools.PlotPanel import PlotPanel
18       
19       You will get an exception: ImportError: No module named fittings
20       
21     Guitools should not depend on your miniView code.
22     
23  5- [QUESTION] Each time you open and close the Fit Dialog, a new label "Theory1D" is created in the
24     legend. There should always be only one, for the _last_ fit, and the name should be "Fit".
25     [alina] is it fine if I delete the fit line from the graph
26      and remove  it when I close the Fit Dialog window?
27     
28  6-[QUESTION ] Do this:
29                a) Load the file 'line_in_logy_x.txt'
30                b) Fit a straight line
31                c) The fit shown does not start from the first point and it's not a straight line.
32        [ALINA] then for transformation to log Do I have to transform x to log and set x linear?
33     
34- NOTES that might help for bugs
35  1- Make sure you are fitting the View data, not the underlying data
36  2- Since you are using the log scale from matplotlib, the fit for when one of
37                the axis is in log will NOT be a straight line
38  3- Make sure that you are filling the View of the fit result correctly.
39  [ALINA] not using the log of matplotlib anymore but the axis are never in the log scale by the value are in log10 x
40
41- NEEDED IMPROVEMENTS
42  1-[DONE] After loading a new file or changing the scale using the "Properties" menu, remove any previously displayed fit from the graph.
43 
44  2- There are additional y scales we need: y, y^2, log(y), 1/y, 1/sqrt(y), log(y * x), log(y * x^2)
45  3- You should change the label according to what the user chose, and not hard-code them.
46     For example, in PlotPanel._onEVT_FUNC_PROPERTY, replace
47         
48            self.graph.xaxis('\\rm{q^{2}} ', 'A^{-2}')
49         
50         with
51            name, units = self.some_plottable.get_xaxis()
52            self.graph.xaxis("(%s)^2" % name,  "(%s)^2" % units)
53   
54     That way it still works even if the user is not plotting Intensity versus Q.
55     
56  4- In the fit dialog, put the "fit" and "Close" button in the bottom right corner, like in a standard file dialog.
57  5- The layout of the Fit Dialog should be improved.
58  6- The code should be well documented and clean-up (no print statements).
59 
Note: See TracBrowser for help on using the repository browser.