source: sasview/guitools/requirements.txt @ 3dc83be

ESS_GUIESS_GUI_DocsESS_GUI_batch_fittingESS_GUI_bumps_abstractionESS_GUI_iss1116ESS_GUI_iss879ESS_GUI_iss959ESS_GUI_openclESS_GUI_orderingESS_GUI_sync_sascalccostrafo411magnetic_scattrelease-4.1.1release-4.1.2release-4.2.2release_4.0.1ticket-1009ticket-1094-headlessticket-1242-2d-resolutionticket-1243ticket-1249ticket885unittest-saveload
Last change on this file since 3dc83be was 05da1f89, checked in by Mathieu Doucet <doucetm@…>, 17 years ago

Some mods to improve the look of the fit dialog and fix minor bugs.

  • Property mode set to 100644
File size: 5.0 KB
Line 
1- BUGS
2
3  1- [DONE] After fitting, the fit panel is not updated with the output values of the fit.
4 
5  2- [DONE] Do this:
6      a) load the file line_in_x2_y.txt
7      b) fit a straight line, close the Fit Dialog
8      c) change the scale using the "Properties" menu to x vs y (linear vs linear)
9      You will see an exception that should be fixed.
10
11  3-  [DONE] Load the file line_in_x2_y.txt in miniView. Select x^2 and y for the scales. Fit it.
12      a) The fit range is wrong, it's not update for the X^2 view.
13      b) the fit result is wrong
14      c) Even if you update the range, the fit and the plots are wrong.
15     
16  4- [DONE]At the python command prompt, try:
17       from sans.guitools.PlotPanel import PlotPanel
18       
19       You will get an exception: ImportError: No module named fittings
20       
21     Guitools should not depend on your miniView code.
22     
23  5- [QUESTION] Each time you open and close the Fit Dialog, a new label "Theory1D" is created in the
24     legend. There should always be only one, for the _last_ fit, and the name should be "Fit".
25     [alina] is it fine if I delete the fit line from the graph
26      and remove  it when I close the Fit Dialog window?
27     [Mathieu] That might work. I kind of like it. Let's do it like that and see what the users
28      need.
29     
30  6-[QUESTION ] Do this:
31                a) Load the file 'line_in_logy_x.txt'
32                b) Fit a straight line
33                c) The fit shown does not start from the first point and it's not a straight line.
34        [ALINA] then for transformation to log Do I have to transform x to log and set x linear?
35        [Mathieu] No. That would confuse the user, who expects a log scale. The answer here is to fit
36         y = A * log(x) + B, which is a straight line in the y vs log(x) representation.
37         
38--> [ALINA] woring better...I am concerned how to fit a straight line when x is changing too?
39         
40     
41- NOTES that might help for bugs
42  1- Make sure you are fitting the View data, not the underlying data
43  2- Since you are using the log scale from matplotlib, the fit for when one of
44                the axis is in log will NOT be a straight line
45  3- Make sure that you are filling the View of the fit result correctly.
46  [ALINA] not using the log of matplotlib anymore but the axis are never in the log scale by the value are in log10 x
47  [Mathieu] See my comment to point 6. The right answer is to go back to using the log scale of matplotlib.
48
49- NEEDED IMPROVEMENTS
50  1-[DONE] After loading a new file or changing the scale using the "Properties" menu, remove any previously displayed fit from the graph.
51 
52  2- There are additional y scales we need: y, y^2, log(y), 1/y, 1/sqrt(y), log(y * x), log(y * x^2)
53  [QUESTION] when plottong y=log(y*x) is the user allowed to do transformation on x at the same time
54  for example x---> log X with  y=log(x*y)
55  [PROBLEM]WITH  log(y * x), log(y * x^2)
56       
57  3-[DONE] You should change the label according to what the user chose, and not hard-code them.
58     For example, in PlotPanel._onEVT_FUNC_PROPERTY, replace
59         
60            self.graph.xaxis('\\rm{q^{2}} ', 'A^{-2}')
61         
62         with
63            name, units = self.some_plottable.get_xaxis()
64            self.graph.xaxis("(%s)^2" % name,  "(%s)^2" % units)
65   
66     That way it still works even if the user is not plotting Intensity versus Q.
67     
68  4- [DONE] In the fit dialog, put the "fit" and "Close" button in the bottom right corner, like in a standard file dialog.
69 
70  5- The layout of the Fit Dialog should be improved.
71 
72  6- The code should be well documented and clean-up (no print statements).
73 
74 
75 
76  AFTER TALKING WITH STEEVE KLEIN
77 
78 This is a list the changes Steeve wants :
79 
80  1- [DONE] Add curves : ln(y) in linear scale, ln(x^(4)*I)
81 
82  2- [DONE]Specify in the fitDialog if natural log or log base 10
83 
84  3- [FIXED]When fitting sphere.txt , logx --logy ,fitting is not correct
85 
86  4- [FIXED]the line to fit always is displayed from x min to max all the time even if xmin is changed
87     or xmax is changed
88     
89  5- [FIXED]The fitting errors are too small (order of 10^(-7))for that case too,certainly wrong
90 
91  6- When to see errors bars appear when loading sphere.txt file.
92 
93  7- Add zoom in option when xmax and xmin(user) are entered.
94 
95  8-[FIXED] Always want to know the initial value of xmin and xmax when opening the fitDialog.These values
96     should always be independant of the transformation
97     
98  9-[FIXED] the user should be able to add point to fit without knowing the exact range or guessing
99                a range to fit.
100
101        TO Dr. MATHIEU
102  1- I probably have to change the interface of the fitdialog, I would like to discuss
103     it before proceeding
104        ALINA
105 1- Would like to change the y axis label display
106 
107 
108Cleaning up for deployment:
109
110 - When zooming, check that the new lower bound is positive if on a log scale [DONE]
111 - Fixed bug with the zooming dependency on scale [DONE]
112 - Improved look of Fit dialog [DONE]
113 
114 - Improve labels
115 
116 - Problem scales:
117     - x vs 1/y
118     
Note: See TracBrowser for help on using the repository browser.