#657 closed defect (fixed)
remove scale and background from structure factor
| Reported by: | pkienzle | Owned by: | ajj |
|---|---|---|---|
| Priority: | blocker | Milestone: | SasView 4.1.0 |
| Component: | SasView | Keywords: | |
| Cc: | Work Package: | SasView Bug Fixing |
Description
sasmodels automatically adds scale and background to every model, including structure factors. This is built into the calculation engine.
Easiest way to implement this is to update modelinfo.py so that when self.structure_factor is True, get_hidden_parameters() hides scale and background and make_model_info() so that background is 0 (that is, parameters.kernel_parameters[1].default=0)
Change History (12)
comment:1 Changed 8 years ago by butler
- Milestone changed from SasView 4.0.0 to SasView 4.1.0
comment:2 Changed 8 years ago by mathieu
- Owner set to mathieu
- Status changed from new to accepted
comment:3 Changed 8 years ago by mathieu
comment:4 Changed 8 years ago by pkienzle
- Priority changed from minor to blocker
Changed status to blocker in accordance to Andrew's duplicate ticket.
comment:5 Changed 8 years ago by mathieu
Whooops. Typed in the wrong window…
comment:6 Changed 8 years ago by mathieu
- Owner changed from mathieu to ajj
- Status changed from accepted to assigned
comment:7 Changed 8 years ago by Paul Kienzle <pkienzle@…>
- Resolution set to fixed
- Status changed from assigned to closed
comment:8 Changed 8 years ago by pkienzle
Note: the parameters are only hidden in the sasview model wrapper, not in the underlying model. This is either a bug or a feature. If no other applications that use sasmodels need access to background and scale, then each of them will need their own code to hide scale and parameter, so this is a bug, but if any application might want access to these parameters then it is a feature.
comment:9 Changed 8 years ago by ajj
Eventually sasmodels should not be adding scale and background for structure factors at all as this is not physically meaningful. However, that is a bigger task and the immediate issue of making sasview behave the way users would expect is fixed.
The team decided to prepend [plug-in] to all plug-in model names.
AJJ (2016-10-10) - Is this related to this ticket?