Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#657 closed defect (fixed)

remove scale and background from structure factor

Reported by: pkienzle Owned by: ajj
Priority: blocker Milestone: SasView 4.1.0
Component: SasView Keywords:
Cc: Work Package: SasView Bug Fixing

Description

sasmodels automatically adds scale and background to every model, including structure factors. This is built into the calculation engine.

Easiest way to implement this is to update modelinfo.py so that when self.structure_factor is True, get_hidden_parameters() hides scale and background and make_model_info() so that background is 0 (that is, parameters.kernel_parameters[1].default=0)

Change History (12)

comment:1 Changed 5 years ago by butler

  • Milestone changed from SasView 4.0.0 to SasView 4.1.0

comment:2 Changed 5 years ago by mathieu

  • Owner set to mathieu
  • Status changed from new to accepted

comment:3 Changed 5 years ago by mathieu

The team decided to prepend [plug-in] to all plug-in model names.

Version 0, edited 5 years ago by mathieu (next)

comment:4 Changed 5 years ago by pkienzle

  • Priority changed from minor to blocker

Changed status to blocker in accordance to Andrew's duplicate ticket.

comment:5 Changed 5 years ago by mathieu

Whooops. Typed in the wrong window…

comment:6 Changed 5 years ago by mathieu

  • Owner changed from mathieu to ajj
  • Status changed from accepted to assigned

comment:7 Changed 5 years ago by Paul Kienzle <pkienzle@…>

  • Resolution set to fixed
  • Status changed from assigned to closed

In 8f93522534f116a687112a0b7e9a739c6d0e03a4/sasmodels:

hide structure factor background/scale from sasview gui. Fixes #657.

comment:8 Changed 5 years ago by pkienzle

Note: the parameters are only hidden in the sasview model wrapper, not in the underlying model. This is either a bug or a feature. If no other applications that use sasmodels need access to background and scale, then each of them will need their own code to hide scale and parameter, so this is a bug, but if any application might want access to these parameters then it is a feature.

comment:9 Changed 5 years ago by ajj

Eventually sasmodels should not be adding scale and background for structure factors at all as this is not physically meaningful. However, that is a bigger task and the immediate issue of making sasview behave the way users would expect is fixed.

comment:10 Changed 5 years ago by ajj

In 68669da9154d53fe949cb741efa850cd516ce157/sasview:

Updating MultiplicationModel? to deal with results of fixing #657.

Fixes #750 (again)

comment:11 Changed 5 years ago by ajj

In 736f27e9e612490fce2428fe33d9f38530134575/sasview:

Updating MultiplicationModel? to deal with results of fixing #657.

Fixes #750 (again)

comment:12 Changed 5 years ago by ajj

In be86916245e571a44945c07b0cf0f8c35364fd03/sasmodels:

hide structure factor background/scale from sasview gui. Fixes #657.

Note: See TracTickets for help on using tickets.