Changeset dcabba7 in sasview for src/sas/qtgui/Perspectives/Fitting/FittingLogic.py

Timestamp:

Sep 7, 2018 7:11:28 AM (6 years ago)

Author:

ibressler

Branches:

ESS_GUI, ESS_GUI_batch_fitting, ESS_GUI_bumps_abstraction, ESS_GUI_iss1116, ESS_GUI_iss879, ESS_GUI_opencl, ESS_GUI_ordering, ESS_GUI_sync_sascalc

Children:

fb560d2, c0de493

Parents:

60d55a7

git-author:

Ingo Breßler <dev@…> (09/06/18 07:09:57)

git-committer:

Ingo Breßler <dev@…> (09/07/18 07:11:28)

Message:

ModelThread?: passing calc results by dict instead of tuple

• prevents error when unpacking the tuple in completeXY methods later
• and makes it easier to get just a single value from the result

File:

• src/sas/qtgui/Perspectives/Fitting/FittingLogic.py (modified) (4 diffs)

src/sas/qtgui/Perspectives/Fitting/FittingLogic.py

@@ -161 +161 @@
         Create a new 1D data instance based on fitting results
         """
-        # Unpack return data from Calc1D
-        x, y, page_id, state, weight,\
-        fid, toggle_mode_on, \
-        elapsed, index, model, \
-        data, update_chisqr, source, \
-        unsmeared_output, unsmeared_data, unsmeared_error, \
-        pq_values, sq_values = return_data
-
-        return self._create1DPlot(tab_id, x, y, model, data)
+
+        return self._create1DPlot(tab_id, return_data['x'], return_data['y'],
+                                  return_data['model'], return_data['data'])
 
     def new2DPlot(self, return_data):
@@ -175 +169 @@
         Create a new 2D data instance based on fitting results
         """
-        image, data, page_id, model, state, toggle_mode_on,\
-        elapsed, index, fid, qmin, qmax, weight, \
-        update_chisqr, source = return_data
+        image = return_data['image']
+        data = return_data['data']
+        model = return_data['model']
 
         np.nan_to_num(image)
@@ -183 +177 @@
         new_plot.name = model.name + '2d'
         new_plot.title = "Analytical model 2D "
-        new_plot.id = str(page_id) + " " + data.name
-        new_plot.group_id = str(page_id) + " Model2D"
+        new_plot.id = str(return_data['page_id']) + " " + data.name
+        new_plot.group_id = str(return_data['page_id']) + " Model2D"
         new_plot.detector = data.detector
         new_plot.source = data.source
@@ -218 +212 @@
         (pq_plot, sq_plot). If either are unavailable, the corresponding plot is None.
         """
-        # Unpack return data from Calc1D
-        x, y, page_id, state, weight, \
-        fid, toggle_mode_on, \
-        elapsed, index, model, \
-        data, update_chisqr, source, \
-        unsmeared_output, unsmeared_data, unsmeared_error, \
-        pq_values, sq_values = return_data
 
         pq_plot = None
         sq_plot = None
 
-        if pq_values is not None:
-            pq_plot = self._create1DPlot(tab_id, x, pq_values, model, data, component="P(Q)")
-        if sq_values is not None:
-            sq_plot = self._create1DPlot(tab_id, x, sq_values, model, data, component="S(Q)")
+        if return_data.get('pq_values', None) is not None:
+            pq_plot = self._create1DPlot(tab_id, return_data['x'],
+                    return_data['pq_values'], return_data['model'],
+                    return_data['data'], component="P(Q)")
+        if return_data.get('sq_values', None) is not None:
+            sq_plot = self._create1DPlot(tab_id, return_data['x'],
+                    return_data['sq_values'], return_data['model'],
+                    return_data['data'], component="S(Q)")
 
         return pq_plot, sq_plot