Changeset b297ba9 in sasmodels for sasmodels/models/be_polyelectrolyte.py

Timestamp:

Mar 20, 2019 5:03:50 PM (5 years ago)

Author:

Paul Kienzle <pkienzle@…>

Branches:

master, core_shell_microgels, magnetic_model, ticket-1257-vesicle-product, ticket_1156, ticket_1265_superball, ticket_822_more_unit_tests

Children:

4e28511

Parents:

0d362b7

Message:

lint

File:

• sasmodels/models/be_polyelectrolyte.py (modified) (5 diffs)

sasmodels/models/be_polyelectrolyte.py

@@ -36 +36 @@
   constituting the polymer monomer and the solvent molecules, respectively.
 
-- $v_p$ and $v_s$ are the partial molar volume of the polymer and the 
+- $v_p$ and $v_s$ are the partial molar volume of the polymer and the
   solvent, respectively.
 
@@ -50 +50 @@
 - $C_s$ is the concentration of monovalent salt(1/|Ang^3| - internally converted from mol/L).
 
-- $\alpha$ is the degree of ionization (the ratio of charged monomers to the total 
+- $\alpha$ is the degree of ionization (the ratio of charged monomers to the total
   number of monomers)
 
@@ -74 +74 @@
 dimensionally useful units of 1/|Ang^3|, only the converted version of the
 polymer concentration was actually being used in the calculation while the
-unconverted salt concentration (still in apparent units of mol/L) was being 
-used.  This was carried through to Sasmodels as used for SasView 4.1 (though 
-the line of code converting the salt concentration to the new units was removed 
-somewhere along the line). Simple dimensional analysis of the calculation shows 
-that the converted salt concentration should be used, which the original code 
-suggests was the intention, so this has now been corrected (for SasView 4.2). 
+unconverted salt concentration (still in apparent units of mol/L) was being
+used.  This was carried through to Sasmodels as used for SasView 4.1 (though
+the line of code converting the salt concentration to the new units was removed
+somewhere along the line). Simple dimensional analysis of the calculation shows
+that the converted salt concentration should be used, which the original code
+suggests was the intention, so this has now been corrected (for SasView 4.2).
 Once better validation has been performed this note will be removed.
 
@@ -141 +141 @@
     :params: see parameter table
     :return: 1-D form factor for polyelectrolytes in low salt
-    
+
     parameter names, units, default values, and behavior (volume, sld etc) are
     defined in the parameter table.  The concentrations are converted from
@@ -167 +167 @@
 
 def random():
+    """Return a random parameter set for the model."""
     # TODO: review random be_polyelectrolyte model generation
     pars = dict(